Consolidate some more ash tray constants.

Consolidate some more ash tray constants.

BUG=693282
Review-Url: https://codereview.chromium.org/2709903004
Cr-Commit-Position: refs/heads/master@{#453847}
Committed: https://chromium.googlesource.com/chromium/src/+/da123cacc94145db78abf09bcc10c1c5008ef0d0

[Evan Stade, 2017-02-23 02:19:06]

estade@chromium.org changed reviewers:
+ tdanderson@chromium.org

[Evan Stade, 2017-02-23 02:19:10]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 02:19:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 02:23:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 02:23:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Evan Stade, 2017-02-28 03:25:31]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 03:26:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 03:30:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 03:30:38]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tdanderson, 2017-02-28 17:08:18]

LGTM with nits

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/audio/volume_view.cc (right):

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/audio/volume_view.cc:189:
views::CreateEmptyBorder(gfx::Insets(0, kTrayPopupButtonEndMargin)));
nit: consider renaming to kTrayPopupButtonHorizontalMargin /  or similar and
update the documentation in tray_constants.h

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/network/network_state_list_detailed_view.cc
(right):

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/network/network_state_list_detailed_view.cc:236:
return gfx::Size(size, size);
nit: |size| not needed, just use constant itself as arguments

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/hover_highlight_view.cc (right):

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
ash/common/system/tray/hover_highlight_view.cc:376: const int default_height =
kTrayPopupItemMinHeight;
nit: local variable not needed

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/throbber_view.cc (right):

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
ash/common/system/tray/throbber_view.cc:51: int size = kTrayPopupItemMinHeight;
nit: local variable not needed

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/tray_constants.h (right):

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
ash/common/system/tray/tray_constants.h:60: // The width used for the first
region of the row (usually a more arrow).
nit: end region

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/tray_popup_header_button.cc (right):

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
ash/common/system/tray/tray_popup_header_button.cc:60: int size =
kTrayPopupItemMinHeight;
nit: local variable not needed

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/tray_utils.cc (right):

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
ash/common/system/tray/tray_utils.cc:44: const int tray_image_item_padding =
kTrayImageItemPadding;
nit: local variable no longer needed, just use the constant itself in its place

[Evan Stade, 2017-03-01 04:13:25]

Description was changed from

==========
Consolidate some more ash tray constants.

BUG=693282
==========

to

==========
Consolidate some more ash tray constants.

BUG=693282
==========

[Evan Stade, 2017-03-01 04:28:55]

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/audio/volume_view.cc (right):

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/audio/volume_view.cc:189:
views::CreateEmptyBorder(gfx::Insets(0, kTrayPopupButtonEndMargin)));
On 2017/02/28 17:08:18, tdanderson wrote:
> nit: consider renaming to kTrayPopupButtonHorizontalMargin /  or similar and
> update the documentation in tray_constants.h

I removed the docs, but horizontal margin is just as problematic as end margin
since in other places it's only applied to the end (right).

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/network/network_state_list_detailed_view.cc
(right):

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/network/network_state_list_detailed_view.cc:236:
return gfx::Size(size, size);
On 2017/02/28 17:08:18, tdanderson wrote:
> nit: |size| not needed, just use constant itself as arguments

Done.

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/hover_highlight_view.cc (right):

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
ash/common/system/tray/hover_highlight_view.cc:376: const int default_height =
kTrayPopupItemMinHeight;
On 2017/02/28 17:08:18, tdanderson wrote:
> nit: local variable not needed

Done.

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/throbber_view.cc (right):

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
ash/common/system/tray/throbber_view.cc:51: int size = kTrayPopupItemMinHeight;
On 2017/02/28 17:08:18, tdanderson wrote:
> nit: local variable not needed

Done.

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/tray_constants.h (right):

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
ash/common/system/tray/tray_constants.h:60: // The width used for the first
region of the row (usually a more arrow).
On 2017/02/28 17:08:18, tdanderson wrote:
> nit: end region

Done.

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/tray_popup_header_button.cc (right):

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
ash/common/system/tray/tray_popup_header_button.cc:60: int size =
kTrayPopupItemMinHeight;
On 2017/02/28 17:08:18, tdanderson wrote:
> nit: local variable not needed

Done.

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/tray_utils.cc (right):

https://codereview.chromium.org/2709903004/diff/20001/ash/common/system/tray/...
ash/common/system/tray/tray_utils.cc:44: const int tray_image_item_padding =
kTrayImageItemPadding;
On 2017/02/28 17:08:18, tdanderson wrote:
> nit: local variable no longer needed, just use the constant itself in its
place

Done.

[Evan Stade, 2017-03-01 04:28:57]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-03-01 04:28:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2709903004/#ps40001
(title: "rebase/review")

[commit-bot: I haz the power, 2017-03-01 04:29:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 05:03:01]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488342537936140,
"parent_rev": "b3e92eb163cf654861f80d78feec99bd6cd4cb2e", "commit_rev":
"da123cacc94145db78abf09bcc10c1c5008ef0d0"}

[commit-bot: I haz the power, 2017-03-01 05:03:48]

Description was changed from

==========
Consolidate some more ash tray constants.

BUG=693282
==========

to

==========
Consolidate some more ash tray constants.

BUG=693282

Review-Url: https://codereview.chromium.org/2709903004
Cr-Commit-Position: refs/heads/master@{#453847}
Committed:
https://chromium.googlesource.com/chromium/src/+/da123cacc94145db78abf09bcc10...
==========

[commit-bot: I haz the power, 2017-03-01 05:03:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/da123cacc94145db78abf09bcc10...