Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 2709903002: Add metric for tracking media playback utilization. (Closed)

Created:
3 years, 10 months ago by DaleCurtis
Modified:
3 years, 10 months ago
Reviewers:
Ilya Sherman, xhwang
CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add metric for tracking media playback utilization. I.e., how many players completed preload but never saw playback. This will be handy in terms of guiding efforts to reduce the number of these types of "useless" players. I.e. maybe deferred offscreen loading, etc. BUG=694855 TEST=manual Review-Url: https://codereview.chromium.org/2709903002 Cr-Commit-Position: refs/heads/master@{#452135} Committed: https://chromium.googlesource.com/chromium/src/+/c58ff8ebedea639ba58fb30a2e29faca9f8a0407

Patch Set 1 #

Total comments: 6

Patch Set 2 : Use custom boolean for metric. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M content/browser/media/media_internals.cc View 4 chunks +17 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
DaleCurtis
3 years, 10 months ago (2017-02-22 01:13:12 UTC) #2
Ilya Sherman
LGTM % comments https://codereview.chromium.org/2709903002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2709903002/diff/1/tools/metrics/histograms/histograms.xml#newcode25835 tools/metrics/histograms/histograms.xml:25835: +<histogram name="Media.HasEverPlayed" units="Boolean"> nit: Please use ...
3 years, 10 months ago (2017-02-22 01:27:42 UTC) #3
xhwang
LGTM Does it make sense to differentiate between auto-play players, and non-auto-play players? I guess ...
3 years, 10 months ago (2017-02-22 01:32:20 UTC) #4
DaleCurtis
https://codereview.chromium.org/2709903002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2709903002/diff/1/tools/metrics/histograms/histograms.xml#newcode25835 tools/metrics/histograms/histograms.xml:25835: +<histogram name="Media.HasEverPlayed" units="Boolean"> On 2017/02/22 at 01:27:42, Ilya Sherman ...
3 years, 10 months ago (2017-02-22 01:33:16 UTC) #5
DaleCurtis
For my purpose I don't think it matters to distinguish autoplay; that will count in ...
3 years, 10 months ago (2017-02-22 01:34:17 UTC) #6
DaleCurtis
Said more clearly, autoplay counts as usage for this purpose.
3 years, 10 months ago (2017-02-22 01:34:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709903002/20001
3 years, 10 months ago (2017-02-22 01:37:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/315679)
3 years, 10 months ago (2017-02-22 09:36:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709903002/20001
3 years, 10 months ago (2017-02-22 16:52:15 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 18:21:36 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c58ff8ebedea639ba58fb30a2e29...

Powered by Google App Engine
This is Rietveld 408576698