third_party/WebKit/Source/core/dom/Element.cpp - Issue 2709813007: Remove WebViewClient::showVirtualKeyboardOnElementFocus()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2709813007: Remove WebViewClient::showVirtualKeyboardOnElementFocus() (Closed)

Patch Set: Addressing dcheng@'s comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index 0c31e20d226e9dc20127852fee2a8992a415a048..373a6cb5b51fee86e8c2010ccb0b2e9c04483a73 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -2692,7 +2692,8 @@ void Element::focus(const FocusParams& params) {

// gesture. Since tracking that across arbitrary boundaries (eg.

// animations) is difficult, for now we match IE's heuristic and bring

// up the keyboard if there's been any gesture since load.

- document().page()->chromeClient().showVirtualKeyboardOnElementFocus();

+ document().page()->chromeClient().showVirtualKeyboardOnElementFocus(

+ *document().frame());

}