Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2709813007: Remove WebViewClient::showVirtualKeyboardOnElementFocus() (Closed)
Patch Set: Addressing dcheng@'s comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * (C) 2007 Eric Seidel (eric@webkit.org) 9 * (C) 2007 Eric Seidel (eric@webkit.org)
10 * 10 *
(...skipping 2674 matching lines...) Expand 10 before | Expand all | Expand 10 after
2685 if (!document().page()->focusController().setFocusedElement( 2685 if (!document().page()->focusController().setFocusedElement(
2686 this, document().frame(), params)) 2686 this, document().frame(), params))
2687 return; 2687 return;
2688 2688
2689 if (document().focusedElement() == this && 2689 if (document().focusedElement() == this &&
2690 document().frame()->hasReceivedUserGesture()) { 2690 document().frame()->hasReceivedUserGesture()) {
2691 // Bring up the keyboard in the context of anything triggered by a user 2691 // Bring up the keyboard in the context of anything triggered by a user
2692 // gesture. Since tracking that across arbitrary boundaries (eg. 2692 // gesture. Since tracking that across arbitrary boundaries (eg.
2693 // animations) is difficult, for now we match IE's heuristic and bring 2693 // animations) is difficult, for now we match IE's heuristic and bring
2694 // up the keyboard if there's been any gesture since load. 2694 // up the keyboard if there's been any gesture since load.
2695 document().page()->chromeClient().showVirtualKeyboardOnElementFocus(); 2695 document().page()->chromeClient().showVirtualKeyboardOnElementFocus(
2696 *document().frame());
2696 } 2697 }
2697 } 2698 }
2698 2699
2699 void Element::updateFocusAppearance( 2700 void Element::updateFocusAppearance(
2700 SelectionBehaviorOnFocus selectionBehavior) { 2701 SelectionBehaviorOnFocus selectionBehavior) {
2701 if (selectionBehavior == SelectionBehaviorOnFocus::None) 2702 if (selectionBehavior == SelectionBehaviorOnFocus::None)
2702 return; 2703 return;
2703 if (isRootEditableElement(*this)) { 2704 if (isRootEditableElement(*this)) {
2704 LocalFrame* frame = document().frame(); 2705 LocalFrame* frame = document().frame();
2705 if (!frame) 2706 if (!frame)
(...skipping 1479 matching lines...) Expand 10 before | Expand all | Expand 10 after
4185 } 4186 }
4186 4187
4187 DEFINE_TRACE_WRAPPERS(Element) { 4188 DEFINE_TRACE_WRAPPERS(Element) {
4188 if (hasRareData()) { 4189 if (hasRareData()) {
4189 visitor->traceWrappers(elementRareData()); 4190 visitor->traceWrappers(elementRareData());
4190 } 4191 }
4191 ContainerNode::traceWrappers(visitor); 4192 ContainerNode::traceWrappers(visitor);
4192 } 4193 }
4193 4194
4194 } // namespace blink 4195 } // namespace blink
OLDNEW
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/core/page/ChromeClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698