Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2709813007: Remove WebViewClient::showVirtualKeyboardOnElementFocus() (Closed)
Patch Set: Made the test better Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
index e017d44a570f1e8ebfdbaf408ecf3730c718fec7..ced00615ed93a738a592c2eb43ccfec11c3bd109 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
@@ -1067,9 +1067,11 @@ void ChromeClientImpl::didAssociateFormControlsAfterLoad(LocalFrame* frame) {
webframe->autofillClient()->didAssociateFormControlsDynamically();
}
-void ChromeClientImpl::showVirtualKeyboardOnElementFocus() {
- if (m_webView->client())
- m_webView->client()->showVirtualKeyboardOnElementFocus();
+void ChromeClientImpl::showVirtualKeyboardOnElementFocus(LocalFrame* frame) {
dcheng 2017/02/27 23:13:29 Nit: pass as mutable reference, as this should nev
EhsanK 2017/03/08 23:38:28 Thanks. You mean LocalFrame&?
+ WebLocalFrameImpl::fromFrame(frame->localFrameRoot())
+ ->frameWidget()
+ ->client()
+ ->showVirtualKeyboardOnElementFocus();
}
void ChromeClientImpl::showUnhandledTapUIIfNeeded(

Powered by Google App Engine
This is Rietveld 408576698