Remove WebViewClient::showVirtualKeyboardOnElementFocus()

third_party/WebKit/Source/web/ChromeClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 1049 matching lines @@
   if (WebViewClient* client = m_webView->client())
     client->draggableRegionsChanged();
 }
 
 void ChromeClientImpl::didAssociateFormControlsAfterLoad(LocalFrame* frame) {
   WebLocalFrameImpl* webframe = WebLocalFrameImpl::fromFrame(frame);
   if (webframe->autofillClient())
     webframe->autofillClient()->didAssociateFormControlsDynamically();
 }
 
-void ChromeClientImpl::showVirtualKeyboardOnElementFocus() {
-  if (m_webView->client())
-    m_webView->client()->showVirtualKeyboardOnElementFocus();
+void ChromeClientImpl::showVirtualKeyboardOnElementFocus(LocalFrame* frame) {

[dcheng, 2017/02/27 23:13:29]

Nit: pass as mutable reference, as this should never be null

[EhsanK, 2017/03/08 23:38:28]

Thanks. You mean LocalFrame&?

+  WebLocalFrameImpl::fromFrame(frame->localFrameRoot())
+      ->frameWidget()
+      ->client()
+      ->showVirtualKeyboardOnElementFocus();
 }
 
 void ChromeClientImpl::showUnhandledTapUIIfNeeded(
     IntPoint tappedPositionInViewport,
     Node* tappedNode,
     bool pageChanged) {
   if (m_webView->client())
     m_webView->client()->showUnhandledTapUIIfNeeded(
         WebPoint(tappedPositionInViewport), WebNode(tappedNode), pageChanged);
 }
@@ skipping 136 matching lines @@
     PresentationController::provideTo(frame, client->presentationClient());
   if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) {
     provideAudioOutputDeviceClientTo(frame,
                                      new AudioOutputDeviceClientImpl(frame));
   }
   if (RuntimeEnabledFeatures::installedAppEnabled())
     InstalledAppController::provideTo(frame, client->relatedAppsFetcher());
 }
 
 }  // namespace blink