Remove WebViewClient::showVirtualKeyboardOnElementFocus()

third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index c2d05760f89da2d2a59c6ff65d6c3f7cecc93e44..a5dea41b5e54565e0192829fd60d7947243d4441 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -11412,4 +11412,43 @@ TEST_F(WebFrameTest, ClearClosedOpener) {
   EXPECT_EQ(nullptr, helper.webView()->mainFrameImpl()->opener());
 }
 
+class ShowVirtualKeyboardObserverWidgetClient
+    : public FrameTestHelpers::TestWebWidgetClient {
+ public:
+  ShowVirtualKeyboardObserverWidgetClient() : m_didShowVirtualKeyboard(false) {}
+
+  void showVirtualKeyboardOnElementFocus() override {
+    m_didShowVirtualKeyboard = true;
+  }
+
+  bool didShowVirtualKeyboard() const { return m_didShowVirtualKeyboard; }
+
+ private:
+  bool m_didShowVirtualKeyboard;
+};
+
+TEST_F(WebFrameTest, ShowVirtualKeyboardOnElementFocus) {
+  FrameTestHelpers::TestWebViewClient viewClient;
+  WebView* view = WebView::create(&viewClient, WebPageVisibilityStateVisible);
+
+  FrameTestHelpers::TestWebRemoteFrameClient remoteClient;
+  view->setMainFrame(remoteClient.frame());
+
+  ShowVirtualKeyboardObserverWidgetClient childWidgetClient;
+  WebLocalFrameImpl* childFrame = FrameTestHelpers::createLocalChild(
+      view->mainFrame()->toWebRemoteFrame(), WebString(), nullptr,
+      &childWidgetClient);
+  EXPECT_EQ(childFrame, view->focusedFrame());
+
+  // Simulate an input element focus leading to Element::focus() call with a
+  // user gesture.
+  static_cast<WebViewImpl*>(view)
+      ->chromeClient()
+      .showVirtualKeyboardOnElementFocus(childFrame->frame());
+
+  // Verify that the right WebWidgetClient has been notified.
+  EXPECT_TRUE(childWidgetClient.didShowVirtualKeyboard());
+  view->close();

[dcheng, 2017/02/23 19:28:48]

FWIW, I don't think this unit test adds much and we should just remove it. If we
do want to test this, I think we should be loading some actual DOM into the page
and then calling HTMLInputElement::focus() and checking that it calls out
correctly. WDYT?

[EhsanK, 2017/02/23 21:06:09]

I agree with not having the test. I intended to load a page initially but was
unable to find a way to have a test WebWidgetClient. I will remove the test if
that is OK.

[dcheng, 2017/02/23 21:10:21]

One option is to use the helpers from FrameTestHelpers: the createLocalChild()
helper takes a WebWidgetClient that you can control. Then you can load HTML into
it using FrameTestHelpers::loadFrame or the like, and verify that the methods
are called.

[EhsanK, 2017/02/27 16:59:56]

Thanks! I also had to make it a proper WebFrameSwapTest to work.

+}
+
 }  // namespace blink