Remove WebViewClient::showVirtualKeyboardOnElementFocus()

third_party/WebKit/Source/web/tests/WebFrameTest.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 11394 matching lines @@
   FrameTestHelpers::TestWebViewClient openerWebViewClient;
   FrameTestHelpers::WebViewHelper openerHelper;
   openerHelper.initialize(false, nullptr, &openerWebViewClient);
   FrameTestHelpers::WebViewHelper helper;
   helper.initializeWithOpener(openerHelper.webView()->mainFrame());
 
   openerHelper.reset();
   EXPECT_EQ(nullptr, helper.webView()->mainFrameImpl()->opener());
 }
 
+class ShowVirtualKeyboardObserverWidgetClient
+    : public FrameTestHelpers::TestWebWidgetClient {
+ public:
+  ShowVirtualKeyboardObserverWidgetClient() : m_didShowVirtualKeyboard(false) {}
+
+  void showVirtualKeyboardOnElementFocus() override {
+    m_didShowVirtualKeyboard = true;
+  }
+
+  bool didShowVirtualKeyboard() const { return m_didShowVirtualKeyboard; }
+
+ private:
+  bool m_didShowVirtualKeyboard;
+};
+
+TEST_F(WebFrameTest, ShowVirtualKeyboardOnElementFocus) {
+  FrameTestHelpers::TestWebViewClient viewClient;
+  WebView* view = WebView::create(&viewClient, WebPageVisibilityStateVisible);
+
+  FrameTestHelpers::TestWebRemoteFrameClient remoteClient;
+  view->setMainFrame(remoteClient.frame());
+
+  ShowVirtualKeyboardObserverWidgetClient childWidgetClient;
+  WebLocalFrameImpl* childFrame = FrameTestHelpers::createLocalChild(
+      view->mainFrame()->toWebRemoteFrame(), WebString(), nullptr,
+      &childWidgetClient);
+  EXPECT_EQ(childFrame, view->focusedFrame());
+
+  // Simulate an input element focus leading to Element::focus() call with a
+  // user gesture.
+  static_cast<WebViewImpl*>(view)
+      ->chromeClient()
+      .showVirtualKeyboardOnElementFocus(childFrame->frame());
+
+  // Verify that the right WebWidgetClient has been notified.
+  EXPECT_TRUE(childWidgetClient.didShowVirtualKeyboard());
+  view->close();

[dcheng, 2017/02/23 19:28:48]

FWIW, I don't think this unit test adds much and we should just remove it. If we
do want to test this, I think we should be loading some actual DOM into the page
and then calling HTMLInputElement::focus() and checking that it calls out
correctly. WDYT?

[EhsanK, 2017/02/23 21:06:09]

I agree with not having the test. I intended to load a page initially but was
unable to find a way to have a test WebWidgetClient. I will remove the test if
that is OK.

[dcheng, 2017/02/23 21:10:21]

One option is to use the helpers from FrameTestHelpers: the createLocalChild()
helper takes a WebWidgetClient that you can control. Then you can load HTML into
it using FrameTestHelpers::loadFrame or the like, and verify that the methods
are called.

[EhsanK, 2017/02/27 16:59:56]

Thanks! I also had to make it a proper WebFrameSwapTest to work.

+}
+
 }  // namespace blink