Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issue 2709793002: Remove SpotlightActions experimental flag. (Closed)

Created:
3 years, 10 months ago by jif
Modified:
3 years, 10 months ago
Reviewers:
Olivier, sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SpotlightActions experimental flag. BUG=648529 Review-Url: https://codereview.chromium.org/2709793002 Cr-Commit-Position: refs/heads/master@{#451763} Committed: https://chromium.googlesource.com/chromium/src/+/e09adff42771476c2e08d460439f18c8e0e531d1

Patch Set 1 #

Patch Set 2 : Remove experiment from plist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -42 lines) Patch
M ios/chrome/app/application_delegate/user_activity_handler.mm View 2 chunks +0 lines, -5 lines 0 comments Download
M ios/chrome/app/spotlight/actions_spotlight_manager.mm View 2 chunks +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/about_flags.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/chrome/browser/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/experimental_flags.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/chrome/browser/resources/Settings.bundle/Experimental.plist View 1 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
jif
ptal
3 years, 10 months ago (2017-02-21 14:30:02 UTC) #3
Olivier
lgtm
3 years, 10 months ago (2017-02-21 14:31:04 UTC) #4
jif
+sdefresne for owner approval
3 years, 10 months ago (2017-02-21 14:33:29 UTC) #6
sdefresne
lgtm if experimental_flags::IsSpotlightActionsEnabled() was always returning true
3 years, 10 months ago (2017-02-21 14:38:18 UTC) #9
jif
On 2017/02/21 14:38:18, sdefresne wrote: > lgtm if experimental_flags::IsSpotlightActionsEnabled() was always returning > true It ...
3 years, 10 months ago (2017-02-21 14:49:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709793002/20001
3 years, 10 months ago (2017-02-21 14:49:20 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 15:04:52 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e09adff42771476c2e08d460439f...

Powered by Google App Engine
This is Rietveld 408576698