Add DIR_ROAMING_USER_DATA to PathService.

Add DIR_ROAMING_USER_DATA to PathService.

It maps a directory structure similar to DIR_USER_DATA rooted at the
roaming profile folder on Windows.

Currently not on other platforms.

BUG=657810
TEST=None

Review-Url: https://codereview.chromium.org/2709783002
Cr-Commit-Position: refs/heads/master@{#452815}
Committed: https://chromium.googlesource.com/chromium/src/+/615bd3e1e12e883d5c5709055ea7347c151c5458

[pastarmovj, 2017-02-21 14:36:41]

pastarmovj@chromium.org changed reviewers:
+ thestig@chromium.org

[pastarmovj, 2017-02-21 14:36:41]

Hi Lei,

Welcome back! Would you mind having a look at this rather small CL?

Best,
Julian

[Lei Zhang, 2017-02-23 02:04:08]

lgtm

https://codereview.chromium.org/2709783002/diff/20001/chrome/common/chrome_pa...
File chrome/common/chrome_paths_internal.h (right):

https://codereview.chromium.org/2709783002/diff/20001/chrome/common/chrome_pa...
chrome/common/chrome_paths_internal.h:34: #endif  // OS_WIN
nit: Omit since the block is so short, or use "defined(OS_WIN)" to actually
match the #if. Yes, I see line 105 below doesn't have the defined() either.

[pastarmovj, 2017-02-24 13:28:38]

https://codereview.chromium.org/2709783002/diff/20001/chrome/common/chrome_pa...
File chrome/common/chrome_paths_internal.h (right):

https://codereview.chromium.org/2709783002/diff/20001/chrome/common/chrome_pa...
chrome/common/chrome_paths_internal.h:34: #endif  // OS_WIN
On 2017/02/23 02:04:08, Lei Zhang (super slow) wrote:
> nit: Omit since the block is so short, or use "defined(OS_WIN)" to actually
> match the #if. Yes, I see line 105 below doesn't have the defined() either.

Done.

[pastarmovj, 2017-02-24 13:29:03]

The CQ bit was checked by pastarmovj@chromium.org

[pastarmovj, 2017-02-24 13:29:03]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2709783002/#ps40001
(title: "Address comment.")

[commit-bot: I haz the power, 2017-02-24 13:29:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 14:11:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487942943059200,
"parent_rev": "3bf5613be9d6eebe1f4fdfc396295740bb3df96b", "commit_rev":
"615bd3e1e12e883d5c5709055ea7347c151c5458"}

[commit-bot: I haz the power, 2017-02-24 14:12:24]

Description was changed from

==========
Add DIR_ROAMING_USER_DATA to PathService.

It maps a directory structure similar to DIR_USER_DATA rooted at the
roaming profile folder on Windows.

Currently not on other platforms.

BUG=657810
TEST=None
==========

to

==========
Add DIR_ROAMING_USER_DATA to PathService.

It maps a directory structure similar to DIR_USER_DATA rooted at the
roaming profile folder on Windows.

Currently not on other platforms.

BUG=657810
TEST=None

Review-Url: https://codereview.chromium.org/2709783002
Cr-Commit-Position: refs/heads/master@{#452815}
Committed:
https://chromium.googlesource.com/chromium/src/+/615bd3e1e12e883d5c5709055ea7...
==========

[commit-bot: I haz the power, 2017-02-24 14:12:25]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/615bd3e1e12e883d5c5709055ea7...