Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2709703003: Enable HttpFormWarning feature for browser tests (Closed)

Created:
3 years, 10 months ago by elawrence
Modified:
3 years, 10 months ago
Reviewers:
dvadym
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable HttpFormWarning feature for browser tests The HttpFormWarning is enabled by fieldtrial_testing_config.json but that configuration is not used by the official builders, causing the ShowFormNotSecureOnUsernameField browser test to fail when run on the builders. Explicitly enable the feature for the affected browser tests. BUG=693717 Review-Url: https://codereview.chromium.org/2709703003 Cr-Commit-Position: refs/heads/master@{#452026} Committed: https://chromium.googlesource.com/chromium/src/+/d844eb57169233599e3908198e4784236d2bce03

Patch Set 1 #

Patch Set 2 : Fix comments to match style guide #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -105 lines) Patch
M chrome/browser/password_manager/password_manager_browsertest.cc View 1 3 chunks +133 lines, -105 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
elawrence
PTAL? The new browsertest was failing on the official builders because the feature is not ...
3 years, 10 months ago (2017-02-21 18:50:18 UTC) #2
dvadym
LGTM
3 years, 10 months ago (2017-02-22 12:26:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709703003/20001
3 years, 10 months ago (2017-02-22 13:19:43 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 13:23:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d844eb57169233599e3908198e47...

Powered by Google App Engine
This is Rietveld 408576698