Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2709683002: Remove unneeded IconLoader::image_ (Closed)

Created:
3 years, 10 months ago by tzik
Modified:
3 years, 10 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unneeded IconLoader::image_ IconLoader::image_ is defined as a member of IconLoader, but used only locally. This CL narrows its scope to a local variable. Review-Url: https://codereview.chromium.org/2709683002 Cr-Commit-Position: refs/heads/master@{#451885} Committed: https://chromium.googlesource.com/chromium/src/+/c70c6152ab262bdf5c51ca6c525f3687e757b20d

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
M chrome/browser/icon_loader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/icon_loader_auralinux.cc View 1 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/icon_loader_chromeos.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/icon_loader_mac.mm View 1 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/icon_loader_win.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
tzik
PTAL
3 years, 10 months ago (2017-02-21 10:52:27 UTC) #7
oshima
lgtm
3 years, 10 months ago (2017-02-21 13:25:51 UTC) #10
tzik
+sky. PTAL as an owner of //chrome.
3 years, 10 months ago (2017-02-21 13:56:29 UTC) #13
sky
LGTM
3 years, 10 months ago (2017-02-21 18:28:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709683002/20001
3 years, 10 months ago (2017-02-21 23:51:15 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-22 01:55:59 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709683002/20001
3 years, 10 months ago (2017-02-22 03:56:57 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 05:36:49 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c70c6152ab262bdf5c51ca6c525f...

Powered by Google App Engine
This is Rietveld 408576698