Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2709633008: Removed StartProvisionalNavigationExitedWithEmptyNavigationManager metric. (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 10 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, Eugene But (OOO till 7-30), asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed StartProvisionalNavigationExitedWithEmptyNavigationManager metric. BUG=677552 Review-Url: https://codereview.chromium.org/2709633008 Cr-Commit-Position: refs/heads/master@{#452342} Committed: https://chromium.googlesource.com/chromium/src/+/9ae5bc01814c3239ee064df73481a25b1cbb2587

Patch Set 1 #

Total comments: 2

Patch Set 2 : Marked metric as obsolete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 1 chunk +0 lines, -12 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Eugene But (OOO till 7-30)
PTAL
3 years, 10 months ago (2017-02-22 23:09:22 UTC) #2
Ilya Sherman
https://codereview.chromium.org/2709633008/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2709633008/diff/1/tools/metrics/histograms/histograms.xml#oldcode74776 tools/metrics/histograms/histograms.xml:74776: - enum="BooleanHit"> Please mark this as <obsolete> rather than ...
3 years, 10 months ago (2017-02-22 23:20:08 UTC) #5
Eugene But (OOO till 7-30)
PTAL https://codereview.chromium.org/2709633008/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2709633008/diff/1/tools/metrics/histograms/histograms.xml#oldcode74776 tools/metrics/histograms/histograms.xml:74776: - enum="BooleanHit"> On 2017/02/22 23:20:08, Ilya Sherman wrote: ...
3 years, 10 months ago (2017-02-22 23:42:32 UTC) #6
Ilya Sherman
LGTM, thanks.
3 years, 10 months ago (2017-02-22 23:47:47 UTC) #7
Eugene But (OOO till 7-30)
Thank you for quick review!
3 years, 10 months ago (2017-02-22 23:53:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709633008/20001
3 years, 10 months ago (2017-02-22 23:54:49 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 01:55:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9ae5bc01814c3239ee064df73481...

Powered by Google App Engine
This is Rietveld 408576698