Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2709633007: Remove DumpWithoutCrashing() from privet_url_fetcher (Closed)

Created:
3 years, 10 months ago by scottmg
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DumpWithoutCrashing() from privet_url_fetcher Part of trying to rationalize all calls to DumpWithoutCrashing(). It looks like this one is no longer necessary as the related bug is marked fixed. BUG=513505, 694688 Review-Url: https://codereview.chromium.org/2709633007 Cr-Commit-Position: refs/heads/master@{#452175} Committed: https://chromium.googlesource.com/chromium/src/+/0f78a6b4ca7b46cc6047ecea9d09987ed0a16e70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/browser/printing/cloud_print/privet_url_fetcher.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
scottmg
3 years, 10 months ago (2017-02-22 18:50:03 UTC) #4
Vitaly Buka (NO REVIEWS)
lgtm
3 years, 10 months ago (2017-02-22 19:00:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709633007/1
3 years, 10 months ago (2017-02-22 19:00:52 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 20:05:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0f78a6b4ca7b46cc6047ecea9d09...

Powered by Google App Engine
This is Rietveld 408576698