android: Add a test to GSAAccountChangeListener.

android: Add a test to GSAAccountChangeListener.

Checks that broadcasts are received or not depending on the permission
flags.

BUG=614388
Review-Url: https://codereview.chromium.org/2709623003
Cr-Commit-Position: refs/heads/master@{#452230}
Committed: https://chromium.googlesource.com/chromium/src/+/ab76ed3ce3f8171cd5b1db15cdd7b6bbbfa151c3

[Benoit L, 2017-02-21 18:23:44]

lizeb@chromium.org changed reviewers:
+ pasko@chromium.org

[Benoit L, 2017-02-21 18:23:50]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 18:24:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 23:31:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:31:36]

Dry run: This issue passed the CQ dry run.

[pasko, 2017-02-22 13:49:55]

lgtm, thank you for the test!

https://codereview.chromium.org/2709623003/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/gsa/GSAAccountChangeListenerTest.java
(right):

https://codereview.chromium.org/2709623003/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/gsa/GSAAccountChangeListenerTest.java:63:
// This is ugly, but so is checking that some asynchronous call was never
received.
random idea, not required: are broadcasts sent from the single sender ordered on
receiving side? If so, we could send the 2nd that would be received, after which
we can check that the 1st broadcast was not received.

[Benoit L, 2017-02-22 14:31:13]

lizeb@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Benoit L, 2017-02-22 14:31:14]

Thanks!
+yfriedman for OWNERS for javatests/

https://codereview.chromium.org/2709623003/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/gsa/GSAAccountChangeListenerTest.java
(right):

https://codereview.chromium.org/2709623003/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/gsa/GSAAccountChangeListenerTest.java:63:
// This is ugly, but so is checking that some asynchronous call was never
received.
On 2017/02/22 13:49:55, pasko wrote:
> random idea, not required: are broadcasts sent from the single sender ordered
on
> receiving side? If so, we could send the 2nd that would be received, after
which
> we can check that the 1st broadcast was not received.

The answer seems to be "not guaranteed, but almost always"...

[pasko, 2017-02-22 15:45:25]

https://codereview.chromium.org/2709623003/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/gsa/GSAAccountChangeListenerTest.java
(right):

https://codereview.chromium.org/2709623003/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/gsa/GSAAccountChangeListenerTest.java:63:
// This is ugly, but so is checking that some asynchronous call was never
received.
On 2017/02/22 14:31:14, Benoit L wrote:
> On 2017/02/22 13:49:55, pasko wrote:
> > random idea, not required: are broadcasts sent from the single sender
ordered
> on
> > receiving side? If so, we could send the 2nd that would be received, after
> which
> > we can check that the 1st broadcast was not received.
> 
> The answer seems to be "not guaranteed, but almost always"...

OK, then the other option is that Yaron suggests something better ..

[Yaron, 2017-02-22 18:23:29]

lgtm

https://codereview.chromium.org/2709623003/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/gsa/GSAAccountChangeListenerTest.java
(right):

https://codereview.chromium.org/2709623003/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/gsa/GSAAccountChangeListenerTest.java:63:
// This is ugly, but so is checking that some asynchronous call was never
received.
On 2017/02/22 15:45:25, pasko wrote:
> On 2017/02/22 14:31:14, Benoit L wrote:
> > On 2017/02/22 13:49:55, pasko wrote:
> > > random idea, not required: are broadcasts sent from the single sender
> ordered
> > on
> > > receiving side? If so, we could send the 2nd that would be received, after
> > which
> > > we can check that the 1st broadcast was not received.
> > 
> > The answer seems to be "not guaranteed, but almost always"...
> 
> OK, then the other option is that Yaron suggests something better ..

yeesh. Not super awesome but I don't have a better suggestion at this point. :(

[Benoit L, 2017-02-22 18:40:07]

The CQ bit was checked by lizeb@chromium.org

[commit-bot: I haz the power, 2017-02-22 18:41:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 22:18:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487788807846620, "parent_rev":
"d1cd84fc98cb4247c918630374f03eeb65182a74", "commit_rev":
"ab76ed3ce3f8171cd5b1db15cdd7b6bbbfa151c3"}

[commit-bot: I haz the power, 2017-02-22 22:19:26]

Description was changed from

==========
android: Add a test to GSAAccountChangeListener.

Checks that broadcasts are received or not depending on the permission
flags.

BUG=614388
==========

to

==========
android: Add a test to GSAAccountChangeListener.

Checks that broadcasts are received or not depending on the permission
flags.

BUG=614388

Review-Url: https://codereview.chromium.org/2709623003
Cr-Commit-Position: refs/heads/master@{#452230}
Committed:
https://chromium.googlesource.com/chromium/src/+/ab76ed3ce3f8171cd5b1db15cdd7...
==========

[commit-bot: I haz the power, 2017-02-22 22:19:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ab76ed3ce3f8171cd5b1db15cdd7...