Increase test coverage for Net.HttpTimeToFirstByte

Increase test coverage for Net.HttpTimeToFirstByte

This CL adds sanity tests to make sure that this metrics
is emitted for completed HTTP url request tasks.

TEST = URLRequestHttp*

Review-Url: https://codereview.chromium.org/2709613013
Cr-Commit-Position: refs/heads/master@{#453723}
Committed: https://chromium.googlesource.com/chromium/src/+/1be4b00ee4d9617054fe5698c05cf4d92f42bf17

[Amey J, 2017-02-23 18:33:05]

Description was changed from

==========
Increase test coverage for Net.HttpTimeToFirstByte

This CL adds sanity tests to make sure that this metrics
is emitted for completed HTTP url request tasks.

TEST = URLRequestHttp*
==========

to

==========
Increase test coverage for Net.HttpTimeToFirstByte

This CL adds sanity tests to make sure that this metrics
is emitted for completed HTTP url request tasks.

TEST = URLRequestHttp*
==========

[Amey J, 2017-02-23 18:33:05]

jahagird@amazon.com changed reviewers:
+ asanka@chromium.org

[Amey J, 2017-02-23 18:33:42]

Hi,

Could you please take a look at this change.

Thanks,
Amey

[asanka, 2017-02-28 20:32:39]

https://codereview.chromium.org/2709613013/diff/1/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/2709613013/diff/1/AUTHORS#newcode48
AUTHORS:48: Amey Jahagirdar <jahagird@amazon.com>
Have you signed the CLA?

https://codereview.chromium.org/2709613013/diff/1/net/url_request/url_request...
File net/url_request/url_request_http_job_unittest.cc (right):

https://codereview.chromium.org/2709613013/diff/1/net/url_request/url_request...
net/url_request/url_request_http_job_unittest.cc:640:
EXPECT_EQ(CountReadBytes(reads, arraysize(reads)),
This check is unnecessary.

https://codereview.chromium.org/2709613013/diff/1/net/url_request/url_request...
net/url_request/url_request_http_job_unittest.cc:666: EXPECT_EQ(0,
request->GetTotalReceivedBytes());
This check is unnecessary.

[asanka, 2017-02-28 20:37:04]

https://codereview.chromium.org/2709613013/diff/1/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/2709613013/diff/1/AUTHORS#newcode48
AUTHORS:48: Amey Jahagirdar <jahagird@amazon.com>
On 2017/02/28 20:32:39, asanka wrote:
> Have you signed the CLA?

Ah I see you are already in the AUTHORS file. You should rebase this CL.

[Amey J, 2017-02-28 21:22:16]

Rebased so that AUTHORS file changes are pulled.

https://codereview.chromium.org/2709613013/diff/1/net/url_request/url_request...
File net/url_request/url_request_http_job_unittest.cc (right):

https://codereview.chromium.org/2709613013/diff/1/net/url_request/url_request...
net/url_request/url_request_http_job_unittest.cc:640:
EXPECT_EQ(CountReadBytes(reads, arraysize(reads)),
On 2017/02/28 20:32:39, asanka wrote:
> This check is unnecessary.

Acknowledged.

https://codereview.chromium.org/2709613013/diff/1/net/url_request/url_request...
net/url_request/url_request_http_job_unittest.cc:666: EXPECT_EQ(0,
request->GetTotalReceivedBytes());
On 2017/02/28 20:32:39, asanka wrote:
> This check is unnecessary.

Acknowledged.

[asanka, 2017-02-28 21:23:07]

New patchset?

[Amey J, 2017-02-28 21:30:31]

On 2017/02/28 21:23:07, asanka wrote:
> New patchset?

Seems like, I posted a message before uploading patch. PTAL Patch Set 2: removed
unncessary checks

[asanka, 2017-02-28 21:30:56]

lgtm

[Amey J, 2017-02-28 21:31:21]

The CQ bit was checked by jahagird@amazon.com

[commit-bot: I haz the power, 2017-02-28 21:32:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 22:14:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488317481193010,
"parent_rev": "c977302ab04b19dad4cd8b82227ec7dbb68c22c8", "commit_rev":
"1be4b00ee4d9617054fe5698c05cf4d92f42bf17"}

[commit-bot: I haz the power, 2017-02-28 22:14:59]

Description was changed from

==========
Increase test coverage for Net.HttpTimeToFirstByte

This CL adds sanity tests to make sure that this metrics
is emitted for completed HTTP url request tasks.

TEST = URLRequestHttp*
==========

to

==========
Increase test coverage for Net.HttpTimeToFirstByte

This CL adds sanity tests to make sure that this metrics
is emitted for completed HTTP url request tasks.

TEST = URLRequestHttp*

Review-Url: https://codereview.chromium.org/2709613013
Cr-Commit-Position: refs/heads/master@{#453723}
Committed:
https://chromium.googlesource.com/chromium/src/+/1be4b00ee4d9617054fe5698c05c...
==========

[commit-bot: I haz the power, 2017-02-28 22:15:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1be4b00ee4d9617054fe5698c05c...