Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2709613009:
[WebCrypto] Use Deprecation instead of UseCounter (Closed)
|
Created:
3 years, 10 months ago by maksims (do not use this acc) Modified:
3 years, 10 months ago Reviewers:
Mike West CC:
blink-reviews, chromium-reviews, haraken Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[WebCrypto] Use Deprecation instead of UseCounter
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Xnn6p4m359o/wjV-Gb_NCwAJ
BUG=641526
Review-Url: https://codereview.chromium.org/2709613009
Cr-Commit-Position: refs/heads/master@{#453098}
Committed: https://chromium.googlesource.com/chromium/src/+/85790fe648ccd80bd9e7a48c9d2357eea3530a51
Patch Set 1 #Patch Set 2 : add message? #
Total comments: 1
Patch Set 3 : fix message #
Total comments: 3
Patch Set 4 : correct wrapping #Patch Set 5 : rebased #
Messages
Total messages: 38 (26 generated)
The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [WebCrypto] Use Deprecation instead of UseCounter BUG=641526 ========== to ========== [WebCrypto] Use Deprecation instead of UseCounter BUG=641526 ==========
maksim.sisov@intel.com changed reviewers: + mkwst@chromium.org
ptal this first step on a way to deprecation
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
As long WebCrypto already disallows non-secure usage, what message should I add? Will that be enough?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2709613009/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/2709613009/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/frame/Deprecation.cpp:427: return "WebCrypto requires secure origin to be used."; How about something like: ``` return String::format( "Web Crypto API usage inside secure frames with non-secure ancestors is deprecated." "The API will no longer be exposed in these contexts as of %s. See " "[link to chromestatus entry] for more details.", milestoneString(M59)); ```
Please also link to the intent thread in the CL description.
The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [WebCrypto] Use Deprecation instead of UseCounter BUG=641526 ========== to ========== [WebCrypto] Use Deprecation instead of UseCounter https://groups.google.com/a/chromium.org/d/msg/blink-dev/Xnn6p4m359o/wjV-Gb_N... BUG=641526 ==========
On 2017/02/23 15:40:13, Mike West (sloooooow) wrote: > Please also link to the intent thread in the CL description. Done!
LGTM % nit. https://codereview.chromium.org/2709613009/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/2709613009/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/frame/Deprecation.cpp:430: "as " Please correct the wrapping here. https://codereview.chromium.org/2709613009/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/frame/Deprecation.cpp:432: "for " And here. :)
https://codereview.chromium.org/2709613009/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/2709613009/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/frame/Deprecation.cpp:432: "for " On 2017/02/24 07:47:30, Mike West (sloooooow) wrote: > And here. :) It just git cl format. I'll ignore its message then.
The CQ bit was checked by maksim.sisov@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org Link to the patchset: https://codereview.chromium.org/2709613009/#ps60001 (title: "correct wrapping")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/02/24 at 08:11:46, maksim.sisov wrote: > https://codereview.chromium.org/2709613009/diff/40001/third_party/WebKit/Sour... > File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): > > https://codereview.chromium.org/2709613009/diff/40001/third_party/WebKit/Sour... > third_party/WebKit/Source/core/frame/Deprecation.cpp:432: "for " > On 2017/02/24 07:47:30, Mike West (sloooooow) wrote: > > And here. :) > > It just git cl format. I'll ignore its message then. `git cl format` does a bad job with strings, because it assumes that the line-breaks you added in were meaningful. *shrug* I usually just write the whole string on one line, and then let `git cl format` break it up for me. :) Thanks for changing it!
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by maksim.sisov@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org Link to the patchset: https://codereview.chromium.org/2709613009/#ps80001 (title: "rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488046117509510,
"parent_rev": "3d75fa82cc20aac57093fd756c2f629750a36eaa", "commit_rev":
"85790fe648ccd80bd9e7a48c9d2357eea3530a51"}
Message was sent while issue was closed.
Description was changed from ========== [WebCrypto] Use Deprecation instead of UseCounter https://groups.google.com/a/chromium.org/d/msg/blink-dev/Xnn6p4m359o/wjV-Gb_N... BUG=641526 ========== to ========== [WebCrypto] Use Deprecation instead of UseCounter https://groups.google.com/a/chromium.org/d/msg/blink-dev/Xnn6p4m359o/wjV-Gb_N... BUG=641526 Review-Url: https://codereview.chromium.org/2709613009 Cr-Commit-Position: refs/heads/master@{#453098} Committed: https://chromium.googlesource.com/chromium/src/+/85790fe648ccd80bd9e7a48c9d23... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/85790fe648ccd80bd9e7a48c9d23... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
