Merged: [wasm] Embedder can control what buffers wasm compilation works on.

Merged: [wasm] Embedder can control what buffers wasm compilation works on.

Revision: b40d44ecc1ea662ea6d30d703cf1820cea9ee190

BUG=v8:5981
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=mtrofin@chromium.org

Review-Url: https://codereview.chromium.org/2709613008 .
Cr-Commit-Position: refs/branch-heads/5.7@{#130}
Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1}
Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426}
Committed: https://chromium.googlesource.com/v8/v8/+/b98b2190bf24960388760146c771fa94b4860ac0

[bradnelson, 2017-02-22 22:21:33]

NOTE: This script will no longer automatically update include/v8-version.h and
create a tag. This is done automatically by the autotag bot. Please call the
merge_to_branch.py with --help for more information.

[Mircea Trofin, 2017-02-22 22:22:59]

On 2017/02/22 22:21:33, bradnelson wrote:
> NOTE: This script will no longer automatically update include/v8-version.h and
> create a tag. This is done automatically by the autotag bot. Please call the
> merge_to_branch.py with --help for more information.

LGTM

[bradnelson, 2017-02-22 22:23:50]

Description was changed from

==========
Merged: [wasm] Embedder can control what buffers wasm compilation works on.

Revision: b40d44ecc1ea662ea6d30d703cf1820cea9ee190

BUG=v8:5981
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=mtrofin@chromium.org
==========

to

==========
Merged: [wasm] Embedder can control what buffers wasm compilation works on.

Revision: b40d44ecc1ea662ea6d30d703cf1820cea9ee190

BUG=v8:5981
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=mtrofin@chromium.org

Review-Url: https://codereview.chromium.org/2709613008 .
Cr-Commit-Position: refs/branch-heads/5.7@{#130}
Cr-Branched-From:
975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1}
Cr-Branched-From:
8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426}
Committed:
https://chromium.googlesource.com/v8/v8/+/b98b2190bf24960388760146c771fa94b48...
==========

[bradnelson, 2017-02-22 22:23:51]

Committed patchset #1 (id:1) manually as
b98b2190bf24960388760146c771fa94b4860ac0.

[JaideepBajwa, 2017-02-25 05:13:56]

bjaideep@ca.ibm.com changed reviewers:
+ bjaideep@ca.ibm.com

[JaideepBajwa, 2017-02-25 05:13:57]

Hi,
When building with make/gyp the compiler emits error "error: unused variable
'bytes'" and fails. This will cause projects like nodejs which uses make/gyp to
build v8 to fail.
Is is possible to reland this CL with USE(bytes)?
Master has https://codereview.chromium.org/2695813005/ which is using bytes so
only affecting 5.7.
Thank you.

https://codereview.chromium.org/2709613008/diff/1/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/2709613008/diff/1/src/wasm/wasm-js.cc#newcode250
src/wasm/wasm-js.cc:250: auto bytes = GetFirstArgumentAsBytes(args, &thrower);
USE(bytes);
to suppress compiler unused variable warning

https://codereview.chromium.org/2709613008/diff/1/src/wasm/wasm-js.cc#newcode296
src/wasm/wasm-js.cc:296: auto bytes = GetFirstArgumentAsBytes(args, &thrower);
USE(bytes);
to suppress compiler unused variable warning

[Mircea Trofin, 2017-02-25 05:29:33]

On 2017/02/25 05:13:57, JaideepBajwa wrote:
> Hi,
> When building with make/gyp the compiler emits error "error: unused variable
> 'bytes'" and fails. This will cause projects like nodejs which uses make/gyp
to
> build v8 to fail.
> Is is possible to reland this CL with USE(bytes)?
> Master has https://codereview.chromium.org/2695813005/ which is using bytes so
> only affecting 5.7.
> Thank you.
> 
> https://codereview.chromium.org/2709613008/diff/1/src/wasm/wasm-js.cc
> File src/wasm/wasm-js.cc (right):
> 
>
https://codereview.chromium.org/2709613008/diff/1/src/wasm/wasm-js.cc#newcode250
> src/wasm/wasm-js.cc:250: auto bytes = GetFirstArgumentAsBytes(args, &thrower);
> USE(bytes);
> to suppress compiler unused variable warning
> 
>
https://codereview.chromium.org/2709613008/diff/1/src/wasm/wasm-js.cc#newcode296
> src/wasm/wasm-js.cc:296: auto bytes = GetFirstArgumentAsBytes(args, &thrower);
> USE(bytes);
> to suppress compiler unused variable warning

What would be the preferred way to go about this, should we submit a patch just
in 5.7?

[JaideepBajwa, 2017-02-26 03:24:47]

On 2017/02/25 05:29:33, Mircea Trofin wrote:
> On 2017/02/25 05:13:57, JaideepBajwa wrote:
> > Hi,
> > When building with make/gyp the compiler emits error "error: unused variable
> > 'bytes'" and fails. This will cause projects like nodejs which uses make/gyp
> to
> > build v8 to fail.
> > Is is possible to reland this CL with USE(bytes)?
> > Master has https://codereview.chromium.org/2695813005/ which is using bytes
so
> > only affecting 5.7.
> > Thank you.
> > 
> > https://codereview.chromium.org/2709613008/diff/1/src/wasm/wasm-js.cc
> > File src/wasm/wasm-js.cc (right):
> > 
> >
>
https://codereview.chromium.org/2709613008/diff/1/src/wasm/wasm-js.cc#newcode250
> > src/wasm/wasm-js.cc:250: auto bytes = GetFirstArgumentAsBytes(args,
&thrower);
> > USE(bytes);
> > to suppress compiler unused variable warning
> > 
> >
>
https://codereview.chromium.org/2709613008/diff/1/src/wasm/wasm-js.cc#newcode296
> > src/wasm/wasm-js.cc:296: auto bytes = GetFirstArgumentAsBytes(args,
&thrower);
> > USE(bytes);
> > to suppress compiler unused variable warning
> 
> What would be the preferred way to go about this, should we submit a patch
just
> in 5.7?
Backporting from master won't apply in this case so if patching just 5.7
is acceptable then I've created a patch
https://codereview.chromium.org/2713403002.