Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 2709513004: [ObjC ARC] Converts ios/chrome/app/safe_mode:unit_tests to ARC. (Closed)

Created:
3 years, 10 months ago by stkhapugin
Modified:
3 years, 10 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/app/safe_mode:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2709513004 Cr-Commit-Position: refs/heads/master@{#451752} Committed: https://chromium.googlesource.com/chromium/src/+/0c6f1cf6eb88a9e0a2382f78ec4202a162901c8d

Patch Set 1 #

Total comments: 2

Patch Set 2 : include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M ios/chrome/app/safe_mode/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/app/safe_mode/safe_mode_coordinator_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/app/safe_mode/safe_mode_view_controller_unittest.mm View 5 chunks +16 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
stkhapugin
ptal
3 years, 10 months ago (2017-02-20 17:29:13 UTC) #6
sdefresne
lgtm https://codereview.chromium.org/2709513004/diff/1/ios/chrome/app/safe_mode/safe_mode_coordinator_unittest.mm File ios/chrome/app/safe_mode/safe_mode_coordinator_unittest.mm (right): https://codereview.chromium.org/2709513004/diff/1/ios/chrome/app/safe_mode/safe_mode_coordinator_unittest.mm#newcode9 ios/chrome/app/safe_mode/safe_mode_coordinator_unittest.mm:9: #include "testing/gtest_mac.h" Can this be changed to the ...
3 years, 10 months ago (2017-02-21 09:45:37 UTC) #7
stkhapugin
https://codereview.chromium.org/2709513004/diff/1/ios/chrome/app/safe_mode/safe_mode_coordinator_unittest.mm File ios/chrome/app/safe_mode/safe_mode_coordinator_unittest.mm (right): https://codereview.chromium.org/2709513004/diff/1/ios/chrome/app/safe_mode/safe_mode_coordinator_unittest.mm#newcode9 ios/chrome/app/safe_mode/safe_mode_coordinator_unittest.mm:9: #include "testing/gtest_mac.h" On 2017/02/21 09:45:36, sdefresne wrote: > Can ...
3 years, 10 months ago (2017-02-21 12:23:04 UTC) #8
stkhapugin
3 years, 10 months ago (2017-02-21 12:23:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709513004/20001
3 years, 10 months ago (2017-02-21 12:23:20 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 13:41:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0c6f1cf6eb88a9e0a2382f78ec42...

Powered by Google App Engine
This is Rietveld 408576698