Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2709483007: PPC/s390: [everywhere] Custom representation for frame type (Closed)

Created:
3 years, 10 months ago by JaideepBajwa
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [everywhere] Custom representation for frame type Port fd596007f23a6f33b5d71b76a977400336f55d5a Original Commit Message: Use an opaque format for the frame type marker on the stack, where the marker is simply shifted left by 1 instead of being a Smi. This allows us to generate simpler code for frame initialisation, as we can push a smaller value, decreasing the prologue by 4 bytes and one instruction. R=leszeks@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2709483007 Cr-Commit-Position: refs/heads/master@{#43356} Committed: https://chromium.googlesource.com/v8/v8/+/af76645baac4ba920b97dd55cbdc1df61ff31a39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -37 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 10 months ago (2017-02-21 18:50:36 UTC) #1
john.yan
lgtm
3 years, 10 months ago (2017-02-21 18:55:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709483007/1
3 years, 10 months ago (2017-02-21 18:56:06 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 19:21:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/af76645baac4ba920b97dd55cbdc1df61ff...

Powered by Google App Engine
This is Rietveld 408576698