Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2709483003:
UMA: Add histogram for young generation handling in V8 (Closed)
|
Created:
3 years, 10 months ago by Michael Lippautz Modified:
3 years, 10 months ago CC:
asvitkine+watch_chromium.org, chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUMA: Add histogram for young generation handling in V8
BUG=chromium:693413
Review-Url: https://codereview.chromium.org/2709483003
Cr-Commit-Position: refs/heads/master@{#451786}
Committed: https://chromium.googlesource.com/chromium/src/+/243f0901ba9640fb9bae9af1b14124a0b49d5d2b
Patch Set 1 #Patch Set 2 : Prefix Histogram with V8.GC #
Total comments: 2
Patch Set 3 : Addressed comments. #Messages
Total messages: 25 (16 generated)
mlippautz@chromium.org changed reviewers: + jochen@chromium.org
PTAL V8 side here: https://chromium-review.googlesource.com/c/445156
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Add histogram for young generation handling in V8 BUG= ========== to ========== Add histogram for young generation handling in V8 BUG=chromium:693413 ==========
I can only approve UseCounter additions, sorry
mlippautz@chromium.org changed reviewers: + asvitkine@chromium.org
+asvitkine then, ptal.
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mlippautz@chromium.org changed reviewers: + mpearson@chromium.org
+mpearson as asvitkine is marked as slow :)
https://codereview.chromium.org/2709483003/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2709483003/diff/20001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:73159: +<histogram name="V8.GCYoungGenerationHandling" units="YoungGenerationHandling"> In the other CL it seems to be named V8.YoungGenerationHandling? Also, is this logging an enum? If so, don't use units= and instead use enum= and specify the enum in the XML.
Thanks! https://codereview.chromium.org/2709483003/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2709483003/diff/20001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:73159: +<histogram name="V8.GCYoungGenerationHandling" units="YoungGenerationHandling"> On 2017/02/21 15:19:53, Alexei Svitkine (slow) wrote: > In the other CL it seems to be named V8.YoungGenerationHandling? > The CL got reverted for other reasons on the first try. It landed with the proper name of V8.GCYoungGenerationHandling https://cs.chromium.org/chromium/src/v8/src/counters.h?q=counters.h&sq=packag... > Also, is this logging an enum? If so, don't use units= and instead use enum= and > specify the enum in the XML. Done.
lgtm
The CQ bit was checked by mlippautz@chromium.org
Description was changed from ========== Add histogram for young generation handling in V8 BUG=chromium:693413 ========== to ========== UMA: Add histogram for young generation handling in V8 BUG=chromium:693413 ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487691153795140,
"parent_rev": "038b4317077a2435331352934fad596f36dc6982", "commit_rev":
"243f0901ba9640fb9bae9af1b14124a0b49d5d2b"}
Message was sent while issue was closed.
Description was changed from ========== UMA: Add histogram for young generation handling in V8 BUG=chromium:693413 ========== to ========== UMA: Add histogram for young generation handling in V8 BUG=chromium:693413 Review-Url: https://codereview.chromium.org/2709483003 Cr-Commit-Position: refs/heads/master@{#451786} Committed: https://chromium.googlesource.com/chromium/src/+/243f0901ba9640fb9bae9af1b141... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/243f0901ba9640fb9bae9af1b141... |
