Add internals.textAffinity

Add internals.textAffinity

Add internals.textAffinity to test if cursor is layouted on Upstream/Downstream.
|internals.textAffinity| returns 
 focused Localframe's FrameSelection's TextEditor's SelectionInDOMTree's affinity.

BUG=679977
Review-Url: https://codereview.chromium.org/2709473003
Cr-Commit-Position: refs/heads/master@{#451712}
Committed: https://chromium.googlesource.com/chromium/src/+/88916b8ccc7a34369f8dbe77e71afb4831425df5

[yoichio, 2017-02-20 07:30:22]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 07:30:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 09:27:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 09:27:12]

Dry run: This issue passed the CQ dry run.

[yoichio, 2017-02-21 02:14:25]

Description was changed from

==========
Add internals.textAfinity

BUG=
==========

to

==========
Add internals.textAffinity

Add internals.textAffinity to test if cursor is layouted on Upstream/Downstream.
|internals.textAffinity| returns 
 focused Localframe's FrameSelection's TextEditor's SelectionInDOMTree's
affinity.

BUG=679977
==========

[yoichio, 2017-02-21 02:14:25]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2017-02-21 02:21:13]

https://codereview.chromium.org/2709473003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/testing/Internals.cpp (right):

https://codereview.chromium.org/2709473003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/testing/Internals.cpp:922: .affinity() ==
TextAffinity::Upstream) {
Could you write as:
->selection().selectionInDOMTree().affinity()?

We're going to get rid of FrameSelection::affinity() for simplify
FrameSelection.
Since there are only two call sites (+1 for this patch), we don't need to have
this exposed by FrameSelection.

[yoichio, 2017-02-21 04:38:22]

https://codereview.chromium.org/2709473003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/testing/Internals.cpp (right):

https://codereview.chromium.org/2709473003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/testing/Internals.cpp:922: .affinity() ==
TextAffinity::Upstream) {
On 2017/02/21 02:21:13, yosin_UTC9 wrote:
> Could you write as:
> ->selection().selectionInDOMTree().affinity()?
> 
> We're going to get rid of FrameSelection::affinity() for simplify
> FrameSelection.
> Since there are only two call sites (+1 for this patch), we don't need to have
> this exposed by FrameSelection.

Done.

[yoichio, 2017-02-21 04:38:29]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 04:38:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-21 04:56:46]

lgtm

Thanks!

[yosin_UTC9, 2017-02-21 04:56:49]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-02-21 04:56:51]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-21 04:57:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 05:03:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 05:03:24]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yoichio, 2017-02-21 05:33:11]

yoichio@chromium.org changed reviewers:
+ tkent@chromium.org

[yoichio, 2017-02-21 05:33:12]

Kent, could take a look as OWNER?

[tkent, 2017-02-21 05:48:05]

lgtm

[yoichio, 2017-02-21 06:34:28]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2017-02-21 06:34:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 07:45:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487658868906190,
"parent_rev": "0891c24ebc475fb9b92c1d31a7e8d8e49a7de065", "commit_rev":
"88916b8ccc7a34369f8dbe77e71afb4831425df5"}

[commit-bot: I haz the power, 2017-02-21 07:46:19]

Description was changed from

==========
Add internals.textAffinity

Add internals.textAffinity to test if cursor is layouted on Upstream/Downstream.
|internals.textAffinity| returns 
 focused Localframe's FrameSelection's TextEditor's SelectionInDOMTree's
affinity.

BUG=679977
==========

to

==========
Add internals.textAffinity

Add internals.textAffinity to test if cursor is layouted on Upstream/Downstream.
|internals.textAffinity| returns 
 focused Localframe's FrameSelection's TextEditor's SelectionInDOMTree's
affinity.

BUG=679977

Review-Url: https://codereview.chromium.org/2709473003
Cr-Commit-Position: refs/heads/master@{#451712}
Committed:
https://chromium.googlesource.com/chromium/src/+/88916b8ccc7a34369f8dbe77e71a...
==========

[commit-bot: I haz the power, 2017-02-21 07:46:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/88916b8ccc7a34369f8dbe77e71a...