Selection API: addRange() should be ignored if there is an existing Range.

Selection API: addRange() should be ignored if there is an existing Range.

Blink intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X48eOuLmXOE

This CL increases the number of FAIL tests in external/wpt/selection/ by 336. It's
expected, and we'll update the specification and the tests later.

* editing/selection/addRange.html and addRange-merging.html:
 They are removed because they are tests for the old behavior.

BUG=353069
Review-Url: https://codereview.chromium.org/2709443002
Cr-Commit-Position: refs/heads/master@{#451581}
Committed: https://chromium.googlesource.com/chromium/src/+/552ceb6deed19e86f89eb32b8fb3923217cefd7e

[tkent, 2017-02-20 05:28:36]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 05:28:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 07:01:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 07:01:29]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tkent, 2017-02-20 07:07:57]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 07:08:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-02-20 07:08:14]

Patchset #1 (id:1) has been deleted

[tkent, 2017-02-20 07:12:05]

Description was changed from

==========
Selection API: addRange() should be ignored if there is an existing Range.

BUG=353069
==========

to

==========
Selection API: addRange() should be ignored if there is an existing Range.

This CL increases the number of FAIL tests in external/wpt/selection/ by 336.
It's
expected, and we'll update the draft and the tests later.

BUG=353069
==========

[tkent, 2017-02-20 07:12:38]

Description was changed from

==========
Selection API: addRange() should be ignored if there is an existing Range.

This CL increases the number of FAIL tests in external/wpt/selection/ by 336.
It's
expected, and we'll update the draft and the tests later.

BUG=353069
==========

to

==========
Selection API: addRange() should be ignored if there is an existing Range.

This CL increases the number of FAIL tests in external/wpt/selection/ by 336.
It's
expected, and we'll update the draft and the tests later.

* editing/selection/addRange.html and addRange-merging.html:
 They are removed because they are tests for the old behavior.

BUG=353069
==========

[tkent, 2017-02-20 07:13:54]

Description was changed from

==========
Selection API: addRange() should be ignored if there is an existing Range.

This CL increases the number of FAIL tests in external/wpt/selection/ by 336.
It's
expected, and we'll update the draft and the tests later.

* editing/selection/addRange.html and addRange-merging.html:
 They are removed because they are tests for the old behavior.

BUG=353069
==========

to

==========
Selection API: addRange() should be ignored if there is an existing Range.

This CL increases the number of FAIL tests in external/wpt/selection/ by 336.
It's
expected, and we'll update the specification and the tests later.

* editing/selection/addRange.html and addRange-merging.html:
 They are removed because they are tests for the old behavior.

BUG=353069
==========

[tkent, 2017-02-20 07:14:38]

Description was changed from

==========
Selection API: addRange() should be ignored if there is an existing Range.

This CL increases the number of FAIL tests in external/wpt/selection/ by 336.
It's
expected, and we'll update the specification and the tests later.

* editing/selection/addRange.html and addRange-merging.html:
 They are removed because they are tests for the old behavior.

BUG=353069
==========

to

==========
Selection API: addRange() should be ignored if there is an existing Range.

Blink intent:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X48eOuLmXOE

This CL increases the number of FAIL tests in external/wpt/selection/ by 336.
It's
expected, and we'll update the specification and the tests later.

* editing/selection/addRange.html and addRange-merging.html:
 They are removed because they are tests for the old behavior.

BUG=353069
==========

[tkent, 2017-02-20 07:15:27]

Description was changed from

==========
Selection API: addRange() should be ignored if there is an existing Range.

Blink intent:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X48eOuLmXOE

This CL increases the number of FAIL tests in external/wpt/selection/ by 336.
It's
expected, and we'll update the specification and the tests later.

* editing/selection/addRange.html and addRange-merging.html:
 They are removed because they are tests for the old behavior.

BUG=353069
==========

to

==========
Selection API: addRange() should be ignored if there is an existing Range.

Blink intent:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X48eOuLmXOE

This CL increases the number of FAIL tests in external/wpt/selection/ by 336.
It's
expected, and we'll update the specification and the tests later.

* editing/selection/addRange.html and addRange-merging.html:
 They are removed because they were tests for the old behavior.

BUG=353069
==========

[tkent, 2017-02-20 07:15:34]

Description was changed from

==========
Selection API: addRange() should be ignored if there is an existing Range.

Blink intent:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X48eOuLmXOE

This CL increases the number of FAIL tests in external/wpt/selection/ by 336.
It's
expected, and we'll update the specification and the tests later.

* editing/selection/addRange.html and addRange-merging.html:
 They are removed because they were tests for the old behavior.

BUG=353069
==========

to

==========
Selection API: addRange() should be ignored if there is an existing Range.

Blink intent:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X48eOuLmXOE

This CL increases the number of FAIL tests in external/wpt/selection/ by 336.
It's
expected, and we'll update the specification and the tests later.

* editing/selection/addRange.html and addRange-merging.html:
 They are removed because they are tests for the old behavior.

BUG=353069
==========

[tkent, 2017-02-20 07:16:02]

tkent@chromium.org changed reviewers:
+ yoichio@chromium.org, yosin@chromium.org

[tkent, 2017-02-20 07:16:03]

yoichio@, yosin@, would you review this please?

[yosin_UTC9, 2017-02-20 07:33:41]

lgtm

Thanks for resolving Web developer's pain and providing predictable behavior!

[yoichio, 2017-02-20 07:42:20]

https://codereview.chromium.org/2709443002/diff/10001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2709443002/diff/10001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:612:
newRange->startContainer()->treeScope()) {
Why do you leave these two early returns though you remove above one?

[tkent, 2017-02-20 07:53:25]

https://codereview.chromium.org/2709443002/diff/10001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2709443002/diff/10001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:612:
newRange->startContainer()->treeScope()) {
On 2017/02/20 at 07:42:19, yoichio wrote:
> Why do you leave these two early returns though you remove above one?

The removed one was dead code. We check Document identify by the second 'if' in
this function.

[yoichio, 2017-02-20 08:04:32]

lgtm

[commit-bot: I haz the power, 2017-02-20 08:42:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 08:42:11]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-02-20 08:44:27]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-02-20 08:44:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 08:49:07]

CQ is committing da patch.

Bot data: {"patchset_id": 10001, "attempt_start_ts": 1487580267786790,
"parent_rev": "1721c372d1626d6ed646b9fb1ac03b6e31e08cec", "commit_rev":
"552ceb6deed19e86f89eb32b8fb3923217cefd7e"}

[commit-bot: I haz the power, 2017-02-20 08:49:46]

Description was changed from

==========
Selection API: addRange() should be ignored if there is an existing Range.

Blink intent:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X48eOuLmXOE

This CL increases the number of FAIL tests in external/wpt/selection/ by 336.
It's
expected, and we'll update the specification and the tests later.

* editing/selection/addRange.html and addRange-merging.html:
 They are removed because they are tests for the old behavior.

BUG=353069
==========

to

==========
Selection API: addRange() should be ignored if there is an existing Range.

Blink intent:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X48eOuLmXOE

This CL increases the number of FAIL tests in external/wpt/selection/ by 336.
It's
expected, and we'll update the specification and the tests later.

* editing/selection/addRange.html and addRange-merging.html:
 They are removed because they are tests for the old behavior.

BUG=353069

Review-Url: https://codereview.chromium.org/2709443002
Cr-Commit-Position: refs/heads/master@{#451581}
Committed:
https://chromium.googlesource.com/chromium/src/+/552ceb6deed19e86f89eb32b8fb3...
==========

[commit-bot: I haz the power, 2017-02-20 08:49:47]

Committed patchset #1 (id:10001) as
https://chromium.googlesource.com/chromium/src/+/552ceb6deed19e86f89eb32b8fb3...