Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 2709393006: Do not show pinned tabs on multiple instances (Closed)

Created:
3 years, 10 months ago by tmartino
Modified:
3 years, 9 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not show pinned tabs on multiple instances BUG=691781 Review-Url: https://codereview.chromium.org/2709393006 Cr-Commit-Position: refs/heads/master@{#453294} Committed: https://chromium.googlesource.com/chromium/src/+/4349089ebb28a0509a0fc20af83c9a2c0912c3ed

Patch Set 1 #

Total comments: 2

Patch Set 2 : pkasting nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -22 lines) Patch
M chrome/browser/ui/startup/startup_tab_provider.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider.cc View 1 3 chunks +24 lines, -16 lines 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider_unittest.cc View 2 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
tmartino
3 years, 10 months ago (2017-02-24 18:44:38 UTC) #4
Peter Kasting
LGTM https://codereview.chromium.org/2709393006/diff/1/chrome/browser/ui/startup/startup_tab_provider.cc File chrome/browser/ui/startup/startup_tab_provider.cc (right): https://codereview.chromium.org/2709393006/diff/1/chrome/browser/ui/startup/startup_tab_provider.cc#newcode213 chrome/browser/ui/startup/startup_tab_provider.cc:213: profile_has_other_tabbed_browser) { Nit: {} unnecessary COuld continue to ...
3 years, 10 months ago (2017-02-25 06:07:07 UTC) #7
tmartino
https://codereview.chromium.org/2709393006/diff/1/chrome/browser/ui/startup/startup_tab_provider.cc File chrome/browser/ui/startup/startup_tab_provider.cc (right): https://codereview.chromium.org/2709393006/diff/1/chrome/browser/ui/startup/startup_tab_provider.cc#newcode213 chrome/browser/ui/startup/startup_tab_provider.cc:213: profile_has_other_tabbed_browser) { On 2017/02/25 at 06:07:07, Peter Kasting wrote: ...
3 years, 9 months ago (2017-02-27 19:22:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709393006/20001
3 years, 9 months ago (2017-02-27 19:22:57 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 19:29:13 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4349089ebb28a0509a0fc20af83c...

Powered by Google App Engine
This is Rietveld 408576698