Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2709393004: Media Controls: Fix time updates when dragging from track not scrubber (Closed)

Created:
3 years, 10 months ago by johnme
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, nessy, szager+layoutwatch_chromium.org, zoltan1, mlamouri+watch-blink_chromium.org, eae+blinkwatch, blink-reviews-layout_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, leviw+renderwatch, feature-media-reviews_chromium.org, dglazkov+blink, jchaffraix+rendering, pdr+renderingwatchlist_chromium.org, blink-reviews, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Controls: Fix time updates when dragging from track not scrubber The current time displayed by media controls wasn't being updated (by calling updateCurrentTimeDisplay) whilst dragging the scrubber, if the drag started from the track (starting in SliderThumbElement::dragFrom) rather than from the scrubber (starting with a mousedown event handled by SliderThumbElement::defaultEventHandler). This was because dragging wasn't being correctly detected (it was checking sliderThumbElement()->isActive(), but the slider thumb doesn't get activated in the dragFrom case). Hence dragging detection has been replaced by robust data from the SliderThumbElement itself. The SliderThumbElement was also tweaked such that it is not marked as dragging for the input event generated by SliderThumbElement::dragFrom's call to setPositionFromPoint, since this movement is the result of the mousedown on the track, not a mousemove (drag). This will also be useful for subsequent UMA (https://crbug.com/693630). BUG=695459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -55 lines) Patch
M third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp View 6 chunks +16 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutSlider.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutSlider.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/core/layout/api/LayoutSliderItem.h View 1 chunk +0 lines, -39 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (5 generated)
johnme
3 years, 9 months ago (2017-03-08 13:16:06 UTC) #6
Message was sent while issue was closed.
Abandoned in favor of https://codereview.chromium.org/2725893002
(792dd3474f7076b0dc33126a90ba4affbaac2c7f).

Powered by Google App Engine
This is Rietveld 408576698