Chromium Code Reviews
DescriptionMedia Controls: Fix time updates when dragging from track not scrubber
The current time displayed by media controls wasn't being updated (by
calling updateCurrentTimeDisplay) whilst dragging the scrubber, if the
drag started from the track (starting in SliderThumbElement::dragFrom)
rather than from the scrubber (starting with a mousedown event handled
by SliderThumbElement::defaultEventHandler).
This was because dragging wasn't being correctly detected (it was
checking sliderThumbElement()->isActive(), but the slider thumb doesn't
get activated in the dragFrom case). Hence dragging detection has been
replaced by robust data from the SliderThumbElement itself.
The SliderThumbElement was also tweaked such that it is not marked as
dragging for the input event generated by SliderThumbElement::dragFrom's
call to setPositionFromPoint, since this movement is the result of the
mousedown on the track, not a mousemove (drag).
This will also be useful for subsequent UMA (https://crbug.com/693630).
BUG=695459
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 6 (5 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||