third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp - Issue 2709393004: Media Controls: Fix time updates when dragging from track not scrubber

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

Issue 2709393004: Media Controls: Fix time updates when dragging from track not scrubber (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp b/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

index 256d2b67600e97b0404b0688c81de1a371647380..5c24ced48699ac50a459516d7ae695fb78b93674 100644

--- a/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

@@ -96,8 +96,10 @@ Node* SliderThumbElement::focusDelegate() {

}

void SliderThumbElement::dragFrom(const LayoutPoint& point) {

- startDragging();

+ // Call setPositionFromPoint before startDragging, since this initial position

+ // change is due to the mousedown on track that precedes dragging (mousemove).

setPositionFromPoint(point);

+ startDragging();

}

void SliderThumbElement::setPositionFromPoint(const LayoutPoint& point) {