Split ArcAuthNotification UI control flag from ArcSessionManager.

Split ArcAuthNotification UI control flag from ArcSessionManager.

ArcSessionManager is now depending on ArcAuthNotification.
In a later CL, it will be extracted into another new class.
As its preparation, this CL extracts the "disabling for testing"
code into the class.

BUG=657687
BUG=b/31079732
TEST=Ran trybots.

Review-Url: https://codereview.chromium.org/2709393003
Cr-Commit-Position: refs/heads/master@{#452577}
Committed: https://chromium.googlesource.com/chromium/src/+/5cb64f9cf9fbe97e44fdedaf319308768424f62e

[hidehiko, 2017-02-23 13:46:50]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 13:47:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 14:13:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 14:13:57]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2017-02-23 14:14:45]

hidehiko@chromium.org changed reviewers:
+ lhchavez@chromium.org

[hidehiko, 2017-02-23 14:14:45]

PTAL.

[Luis Héctor Chávez, 2017-02-23 17:29:32]

lgtm

https://codereview.chromium.org/2709393003/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_notification.h (right):

https://codereview.chromium.org/2709393003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_notification.h:18: // Disables to show
ArcAuthNotification to make testing easier.
nit: "Disables showing"

[hidehiko, 2017-02-23 18:33:34]

Thank you for review. Submitting.

https://codereview.chromium.org/2709393003/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_notification.h (right):

https://codereview.chromium.org/2709393003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_notification.h:18: // Disables to show
ArcAuthNotification to make testing easier.
On 2017/02/23 17:29:32, Luis Héctor Chávez wrote:
> nit: "Disables showing"

Done.

[hidehiko, 2017-02-23 18:33:37]

The CQ bit was checked by hidehiko@chromium.org

[hidehiko, 2017-02-23 18:33:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2709393003/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2017-02-23 18:34:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 19:16:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487874817276530,
"parent_rev": "e9e49a4e35605dfeb0511c751613596d7b16463b", "commit_rev":
"5cb64f9cf9fbe97e44fdedaf319308768424f62e"}

[commit-bot: I haz the power, 2017-02-23 19:17:15]

Description was changed from

==========
Split ArcAuthNotification UI control flag from ArcSessionManager.

ArcSessionManager is now depending on ArcAuthNotification.
In a later CL, it will be extracted into another new class.
As its preparation, this CL extracts the "disabling for testing"
code into the class.

BUG=657687
BUG=b/31079732
TEST=Ran trybots.
==========

to

==========
Split ArcAuthNotification UI control flag from ArcSessionManager.

ArcSessionManager is now depending on ArcAuthNotification.
In a later CL, it will be extracted into another new class.
As its preparation, this CL extracts the "disabling for testing"
code into the class.

BUG=657687
BUG=b/31079732
TEST=Ran trybots.

Review-Url: https://codereview.chromium.org/2709393003
Cr-Commit-Position: refs/heads/master@{#452577}
Committed:
https://chromium.googlesource.com/chromium/src/+/5cb64f9cf9fbe97e44fdedaf3193...
==========

[commit-bot: I haz the power, 2017-02-23 19:17:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5cb64f9cf9fbe97e44fdedaf3193...