Allow to open multiple modal file-pickers in Linux

Allow to open multiple modal file-pickers in Linux

When downloading a file from multiple tabs, we need to open multiple
file-pickers at the same time.

This CL allows to open multiple modal file-pickers in Linux.

BUG=678982
Review-Url: https://codereview.chromium.org/2709283003
Cr-Commit-Position: refs/heads/master@{#453410}
Committed: https://chromium.googlesource.com/chromium/src/+/7ea69fd50d960a0cdba6ea90811332123824d59e

[joone, 2017-02-23 00:46:39]

The CQ bit was checked by joone.hur@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 00:47:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 02:14:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 02:14:49]

Dry run: This issue passed the CQ dry run.

[joone, 2017-02-23 17:53:35]

joone.hur@intel.com changed reviewers:
+ sadrul@chromium.org

[joone, 2017-02-23 17:53:35]

Hi sadrul@ could you review this CL?

[sadrul, 2017-02-25 01:23:11]

https://codereview.chromium.org/2709283003/diff/1/ui/views/widget/desktop_aur...
File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right):

https://codereview.chromium.org/2709283003/diff/1/ui/views/widget/desktop_aur...
ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:2358: if
(!--modal_dialog_counter_)
DCHECK_GT(modal_dialog_counter_, 0);

before decrementing.

[sadrul, 2017-02-25 01:23:19]

lgtm with that nit

[joone, 2017-02-27 22:28:12]

The CQ bit was checked by joone.hur@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 22:29:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joone, 2017-02-27 22:29:38]

joone.hur@intel.com changed reviewers:
+ erg@chromium.org

[joone, 2017-02-27 22:29:39]

erg@ Hi could you review this CL?

[Elliot Glaysher, 2017-02-27 22:40:22]

lgtm

[commit-bot: I haz the power, 2017-02-27 23:33:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 23:33:29]

Dry run: This issue passed the CQ dry run.

[joone, 2017-02-28 00:21:06]

The CQ bit was checked by joone.hur@intel.com

[joone, 2017-02-28 00:21:07]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2709283003/#ps20001
(title: "add DCHECK_GT")

[commit-bot: I haz the power, 2017-02-28 00:21:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 00:27:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488241266944610,
"parent_rev": "43cf179651d67978fa112f436b17359a688a321e", "commit_rev":
"7ea69fd50d960a0cdba6ea90811332123824d59e"}

[commit-bot: I haz the power, 2017-02-28 00:28:08]

Description was changed from

==========
Allow to open multiple modal file-pickers in Linux

When downloading a file from multiple tabs, we need to open multiple
file-pickers at the same time.

This CL allows to open multiple modal file-pickers in Linux.

BUG=678982
==========

to

==========
Allow to open multiple modal file-pickers in Linux

When downloading a file from multiple tabs, we need to open multiple
file-pickers at the same time.

This CL allows to open multiple modal file-pickers in Linux.

BUG=678982

Review-Url: https://codereview.chromium.org/2709283003
Cr-Commit-Position: refs/heads/master@{#453410}
Committed:
https://chromium.googlesource.com/chromium/src/+/7ea69fd50d960a0cdba6ea908113...
==========

[commit-bot: I haz the power, 2017-02-28 00:28:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7ea69fd50d960a0cdba6ea908113...