Add haptic feedback for swipe-to-go-back.

Add haptic feedback for swipe-to-go-back.

For supporting devices (iPhone7), provide haptic feedback when the
user successfully triggers the back/forward action. Also pulse slightly
each time the user crosses the activation threshold.

Also moves haptic trigger routines into uikit_util.h and fixes up
the Overscroll code to use these shared functions.

BUG=695137
TEST=See https://bugs.chromium.org/p/chromium/issues/detail?id=695137#c1 for manual test details.

Review-Url: https://codereview.chromium.org/2709233003
Cr-Commit-Position: refs/heads/master@{#452531}
Committed: https://chromium.googlesource.com/chromium/src/+/6ea20a431c457a98f0de01ce0de4c020a15714b6

[pink (ping after 24hrs), 2017-02-22 19:37:29]

Description was changed from

==========
Add haptic feedback for swipe-to-go-back.

For supporting devices (iPhone7), provide haptic feedback when the
user successfully triggers the back/forward action. Also pulse slightly
each time the user crosses the activation threshold.

Also moves haptic trigger routines into uikit_util.h and fixes up
the Overscroll code to use these shared functions.

BUG=695137
TEST=No automated tests possible.
Manual test on iPhone7:
- on a page with no back session history, swiping should not trigger
any haptics.
- on a page where you can go back, a small blip should be felt each time
the activation threshold is crossed, before you lift your finger.
- Upon releasing to trigger the back action, an additional stronger blip
should be felt.
-
==========

to

==========
Add haptic feedback for swipe-to-go-back.

For supporting devices (iPhone7), provide haptic feedback when the
user successfully triggers the back/forward action. Also pulse slightly
each time the user crosses the activation threshold.

Also moves haptic trigger routines into uikit_util.h and fixes up
the Overscroll code to use these shared functions.

BUG=695137
TEST=See https://bugs.chromium.org/p/chromium/issues/detail?id=695137#c1 for
manual test details.
==========

[pink (ping after 24hrs), 2017-02-22 19:42:16]

pinkerton@chromium.org changed reviewers:
+ justincohen@chromium.org

[justincohen, 2017-02-22 20:56:21]

side_swipe LGTM

[pink (ping after 24hrs), 2017-02-22 21:45:39]

pinkerton@chromium.org changed reviewers:
+ jif@chromium.org, rohitrao@chromium.org

[pink (ping after 24hrs), 2017-02-22 21:45:40]

Adding jif@ for overscroll cleanup
Adding rohitrao@ for ios/chrome/browser changes.

[rohitrao (ping after 24h), 2017-02-23 16:15:54]

https://codereview.chromium.org/2709233003/diff/20001/ios/chrome/browser/ui/u...
File ios/chrome/browser/ui/uikit_ui_util.mm (right):

https://codereview.chromium.org/2709233003/diff/20001/ios/chrome/browser/ui/u...
ios/chrome/browser/ui/uikit_ui_util.mm:670:
base::scoped_nsobject<UIImpactFeedbackGenerator> generator(
This file is ARC, so you shouldn't need to use the scoped_nsobject.

[pink (ping after 24hrs), 2017-02-23 16:22:02]

New version uploaded, PTAL

https://codereview.chromium.org/2709233003/diff/20001/ios/chrome/browser/ui/u...
File ios/chrome/browser/ui/uikit_ui_util.mm (right):

https://codereview.chromium.org/2709233003/diff/20001/ios/chrome/browser/ui/u...
ios/chrome/browser/ui/uikit_ui_util.mm:670:
base::scoped_nsobject<UIImpactFeedbackGenerator> generator(
On 2017/02/23 16:15:54, rohitrao wrote:
> This file is ARC, so you shouldn't need to use the scoped_nsobject.

Done.

[rohitrao (ping after 24h), 2017-02-23 16:22:47]

lgtm

[pink (ping after 24hrs), 2017-02-23 16:23:33]

The CQ bit was checked by pinkerton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 16:24:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 16:53:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 16:53:43]

Dry run: This issue passed the CQ dry run.

[pink (ping after 24hrs), 2017-02-23 17:16:14]

The CQ bit was checked by pinkerton@chromium.org

[pink (ping after 24hrs), 2017-02-23 17:16:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
justincohen@chromium.org
Link to the patchset: https://codereview.chromium.org/2709233003/#ps40001
(title: "File is ARC.")

[commit-bot: I haz the power, 2017-02-23 17:16:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 17:22:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487870174917920,
"parent_rev": "f3fb1282e40b4927115225c53cdd5bdc0359d6c5", "commit_rev":
"6ea20a431c457a98f0de01ce0de4c020a15714b6"}

[commit-bot: I haz the power, 2017-02-23 17:22:34]

Description was changed from

==========
Add haptic feedback for swipe-to-go-back.

For supporting devices (iPhone7), provide haptic feedback when the
user successfully triggers the back/forward action. Also pulse slightly
each time the user crosses the activation threshold.

Also moves haptic trigger routines into uikit_util.h and fixes up
the Overscroll code to use these shared functions.

BUG=695137
TEST=See https://bugs.chromium.org/p/chromium/issues/detail?id=695137#c1 for
manual test details.
==========

to

==========
Add haptic feedback for swipe-to-go-back.

For supporting devices (iPhone7), provide haptic feedback when the
user successfully triggers the back/forward action. Also pulse slightly
each time the user crosses the activation threshold.

Also moves haptic trigger routines into uikit_util.h and fixes up
the Overscroll code to use these shared functions.

BUG=695137
TEST=See https://bugs.chromium.org/p/chromium/issues/detail?id=695137#c1 for
manual test details.

Review-Url: https://codereview.chromium.org/2709233003
Cr-Commit-Position: refs/heads/master@{#452531}
Committed:
https://chromium.googlesource.com/chromium/src/+/6ea20a431c457a98f0de01ce0de4...
==========

[commit-bot: I haz the power, 2017-02-23 17:22:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6ea20a431c457a98f0de01ce0de4...