Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: testing/test.gni

Issue 2709223002: Respect ios_automatically_manage_certs when building EG tests. (Closed)
Patch Set: Address comment. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/test/earl_grey/chrome_ios_eg_test.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/test.gni
diff --git a/testing/test.gni b/testing/test.gni
index b344945ce926854d20a98c0595bb5c26ba8c5a25..407e8f45a050ee202c9c3e04713eeaede949ddcc 100644
--- a/testing/test.gni
+++ b/testing/test.gni
@@ -217,6 +217,7 @@ template("test") {
]
}
} else if (is_ios) {
+ import("//build/config/ios/ios_sdk.gni")
import("//build/config/ios/rules.gni")
_test_target = target_name
@@ -245,11 +246,9 @@ template("test") {
info_plist = "//testing/gtest_ios/unittest-Info.plist"
}
- _bundle_id_suffix = target_name
- if (ios_automatically_manage_certs) {
- # Use the same bundle identifier for all unit tests when managing
- # certificates automatically as the number of free certs is limited.
- _bundle_id_suffix = "generic-unit-test"
+ _bundle_id_suffix = ios_generic_test_bundle_id_suffix
+ if (!ios_automatically_manage_certs) {
+ _bundle_id_suffix = "${target_name}"
}
if (!defined(extra_substitutions)) {
extra_substitutions = []
« no previous file with comments | « ios/chrome/test/earl_grey/chrome_ios_eg_test.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698