Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 27092002: Revert 227219 "Revert 226920 "Roll Clang 188423:191856."" (Closed)

Created:
7 years, 2 months ago by Nico
Modified:
7 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 227219 "Revert 226920 "Roll Clang 188423:191856."" This relands the clang roll from r226920. The symbol issue (http://crbug.com/304846) should be fixed by now, on the crash server side. > Revert 226920 "Roll Clang 188423:191856." > > Possibly broke crash symbolication on mac. > > > Roll Clang 188423:191856. > > > > Remove libprofile_rt from package.sh, it doesn't exist after LLVM r191835 > > > > BUG=290204, 303886 > > R=thakis@chromium.org > > TBR=net owner > > NOTRY=true > > > > Review URL: https://codereview.chromium.org/25875004 > > TBR=thakis@chromium.org > > Review URL: https://codereview.chromium.org/26145004 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -19 lines) Patch
M trunk/src/base/debug/stack_trace_android.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M trunk/src/base/security_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M trunk/src/build/common.gypi View 3 chunks +16 lines, -0 lines 0 comments Download
M trunk/src/net/cert/multi_threaded_cert_verifier_unittest.cc View 1 chunk +7 lines, -1 line 0 comments Download
M trunk/src/tools/clang/scripts/package.sh View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/tools/clang/scripts/update.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
7 years, 2 months ago (2013-10-12 06:02:33 UTC) #1
Nico
7 years, 2 months ago (2013-10-12 06:02:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r228318.

Powered by Google App Engine
This is Rietveld 408576698