Roll Clang 188423:191856.

Roll Clang 188423:191856.

Remove libprofile_rt from package.sh, it doesn't exist after LLVM r191835

BUG=290204, 303886
R=thakis@chromium.org
TBR=net owner
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226920

[hans, 2013-10-03 18:29:43]

This depends on getting the clean-ups landed first, but I figured I'd upload it
in the meantime.

[Nico, 2013-10-03 18:41:41]

https://codereview.chromium.org/25875004/diff/1/sdch/sdch.gyp
File sdch/sdch.gyp (right):

https://codereview.chromium.org/25875004/diff/1/sdch/sdch.gyp#newcode63
sdch/sdch.gyp:63: [ 'clang==1', { 'cflags': ['-Wno-deprecated-declarations'] }
],
I'm guessing this is due to clang r191550 which added support for
[[deprecated]], and auto_ptr is marked [[deprecated]] in at least some versions
of libstdc++.

I'm wondering if we should add this to build/common.gypi instead – auto_ptr
might be deprecated, but the replacement isn't ready yet as not all bots are
building in c++11 mode yet. Then again, I suppose we have scoped_ptr in most
places. (On the third hand, deprecated warnings tend to not work in practice,
see Java.) What do you think?

[hans, 2013-10-03 18:53:27]

On 2013/10/03 18:41:41, Nico wrote:
> https://codereview.chromium.org/25875004/diff/1/sdch/sdch.gyp
> File sdch/sdch.gyp (right):
> 
> https://codereview.chromium.org/25875004/diff/1/sdch/sdch.gyp#newcode63
> sdch/sdch.gyp:63: [ 'clang==1', { 'cflags': ['-Wno-deprecated-declarations'] }
> ],
> I'm guessing this is due to clang r191550 which added support for
> [[deprecated]], and auto_ptr is marked [[deprecated]] in at least some
versions
> of libstdc++.
> 
> I'm wondering if we should add this to build/common.gypi instead
– auto_ptr
> might be deprecated, but the replacement isn't ready yet as not all bots are
> building in c++11 mode yet. Then again, I suppose we have scoped_ptr in most
> places. (On the third hand, deprecated warnings tend to not work in practice,
> see Java.) What do you think?

sgtm

Also suppressing unused const global variables until the clean-ups land, as
discussed offline.

[Nico, 2013-10-03 18:55:15]

lgtm

[Nico, 2013-10-03 18:56:37]

clang:error: unknown argument: '-fuse-ld=gold'

on android. Augh!

[commit-bot: I haz the power, 2013-10-03 21:51:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hans@chromium.org/25875004/33001

[Nico, 2013-10-04 01:11:44]

Committed patchset #8 manually as r226920 (presubmit successful).