Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2709153003: Fix repeat background position problem (Closed)

Created:
3 years, 10 months ago by Sunghoon Kim
Modified:
3 years, 9 months ago
Reviewers:
Stephen Chennney, fs
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, enne (OOO)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix repeat background position problem In the case of right and bottom edge, the factional position within tile should be calculated in same manner on left and top edge. BUG=675689 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2709153003 Cr-Commit-Position: refs/heads/master@{#452576} Committed: https://chromium.googlesource.com/chromium/src/+/e9e49a4e35605dfeb0511c751613596d7b16463b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -24 lines) Patch
A third_party/WebKit/LayoutTests/fast/backgrounds/background-position-repeat-rendering-2.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/backgrounds/background-position-repeat-rendering-2-expected.html View 1 chunk +48 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp View 2 chunks +16 lines, -24 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Sunghoon Kim
Please, review this change. Currently, due to the content_shell crash, i didn't do layout tests. ...
3 years, 10 months ago (2017-02-22 08:17:43 UTC) #3
fs
+schenney who I think has been spending more time with this code than I have. ...
3 years, 10 months ago (2017-02-22 09:52:28 UTC) #5
Stephen Chennney
The change looks good to me. I'm running the try jobs necessary to get layout ...
3 years, 10 months ago (2017-02-22 14:40:44 UTC) #6
Sunghoon Kim
I ran my test and it's succeeded. And I don't know the fail on mac ...
3 years, 10 months ago (2017-02-23 08:29:18 UTC) #7
Stephen Chennney
Next you commit! Thanks for fixing this. lgtm and I'll submit to the CQ for ...
3 years, 9 months ago (2017-02-23 17:25:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709153003/1
3 years, 9 months ago (2017-02-23 17:25:46 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-23 19:16:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e9e49a4e35605dfeb0511c751613...

Powered by Google App Engine
This is Rietveld 408576698