Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2709113002: Remove ArcImeService from window observers on shutdown (Closed)

Created:
3 years, 10 months ago by yoshiki
Modified:
3 years, 10 months ago
Reviewers:
hidehiko, kinaba
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ArcImeService from window observers on shutdown Remaining observer fails CHECK and causes crash. This patch prevents it. BUG=691842 TEST=none Review-Url: https://codereview.chromium.org/2709113002 Cr-Commit-Position: refs/heads/master@{#452417} Committed: https://chromium.googlesource.com/chromium/src/+/a6e727ae6c9a9a9994a87ebb2e1025e9982e15c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/arc/ime/arc_ime_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
yoshiki
kinaba@, PTAL.
3 years, 10 months ago (2017-02-22 06:53:52 UTC) #6
kinaba
thanks! lgtm but you need OWNER review too
3 years, 10 months ago (2017-02-22 07:02:07 UTC) #7
yoshiki
Hidehiko, could you approve this?
3 years, 10 months ago (2017-02-22 07:20:30 UTC) #9
hidehiko
lgtm
3 years, 10 months ago (2017-02-23 05:18:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709113002/1
3 years, 10 months ago (2017-02-23 06:12:12 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 06:17:57 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a6e727ae6c9a9a9994a87ebb2e10...

Powered by Google App Engine
This is Rietveld 408576698