Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2709103007: Update a11y of volume row in CrOS system menu. (Closed)

Created:
3 years, 10 months ago by Evan Stade
Modified:
3 years, 9 months ago
Reviewers:
tdanderson, sadrul
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update a11y of volume row in CrOS system menu. Also remove pre-MD code for VolumeView. TBR=tdanderson@chromium.org BUG=663767 Review-Url: https://codereview.chromium.org/2709103007 Cr-Commit-Position: refs/heads/master@{#453274} Committed: https://chromium.googlesource.com/chromium/src/+/6c951afb46ca38b4740049ee852ab6e877fd10c9

Patch Set 1 #

Patch Set 2 : remove more stuff #

Patch Set 3 : resolve conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -168 lines) Patch
M ash/common/system/chromeos/audio/tray_audio_delegate.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M ash/common/system/chromeos/audio/tray_audio_delegate_chromeos.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/chromeos/audio/tray_audio_delegate_chromeos.cc View 1 2 chunks +0 lines, -18 lines 0 comments Download
M ash/common/system/chromeos/audio/volume_view.h View 3 chunks +0 lines, -6 lines 0 comments Download
M ash/common/system/chromeos/audio/volume_view.cc View 1 2 9 chunks +20 lines, -126 lines 0 comments Download
M ash/common/system/tray/tray_item_more.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/common/system/tray/tray_popup_utils.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 2 3 chunks +0 lines, -7 lines 0 comments Download
D ash/resources/default_100_percent/cros/status/status_audio_device_bluetooth.png View 1 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_audio_device_hdmi.png View 1 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_audio_device_headphones.png View 1 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_audio_device_usb.png View 1 Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_more.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_volume_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_audio_device_bluetooth.png View 1 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_audio_device_hdmi.png View 1 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_audio_device_headphones.png View 1 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_audio_device_usb.png View 1 Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_more.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_volume_dark.png View Binary file 0 comments Download

Messages

Total messages: 17 (11 generated)
Evan Stade
3 years, 10 months ago (2017-02-23 23:16:08 UTC) #2
sadrul
lgtm
3 years, 9 months ago (2017-02-27 16:02:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709103007/40001
3 years, 9 months ago (2017-02-27 18:20:20 UTC) #12
Evan Stade
tbr Terry for asset removal.
3 years, 9 months ago (2017-02-27 18:20:30 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/6c951afb46ca38b4740049ee852ab6e877fd10c9
3 years, 9 months ago (2017-02-27 18:57:58 UTC) #16
tdanderson
3 years, 9 months ago (2017-03-07 16:13:34 UTC) #17
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698