Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2709083006: NTP: Add string for grouped notifications (Closed)

Created:
3 years, 10 months ago by sfiera
Modified:
3 years, 10 months ago
Reviewers:
markusheintz_
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NTP: Add string for grouped notifications This string is used as the message of a notification that links to the NTP instead of directly to a particular article. I'm not 100% certain that it's the exact string we want to use, but I'd like to get some string in by BP, because there's no possibility to merge it later if we find out that link-to-NTP is a blocker. BUG=678268 Review-Url: https://codereview.chromium.org/2709083006 Cr-Commit-Position: refs/heads/master@{#452853} Committed: https://chromium.googlesource.com/chromium/src/+/633a30085db403a43d935bd5e6a9f3eb1053bc85

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M components/ntp_snippets_strings.grdp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sfiera
3 years, 10 months ago (2017-02-24 15:11:13 UTC) #2
markusheintz_
On 2017/02/24 15:11:13, sfiera wrote: LGTM
3 years, 10 months ago (2017-02-24 16:44:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709083006/1
3 years, 10 months ago (2017-02-24 17:01:35 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 17:07:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/633a30085db403a43d935bd5e6a9...

Powered by Google App Engine
This is Rietveld 408576698