Fix incorrectly painted right floats in LayoutNG

Fix incorrectly painted right floats in LayoutNG

This patch fixes several problems discovered while investigating the
issue with incorrectly painted right floats in LayoutNG.

List of changes:

1) NGFloatingObject.parent_space was renamed to original_parent_space
This was discussed in http://crrev.com/2679343004

2) While calculating an additional offset for right floats we need to
use float's box size == float's fragment inline size + float's margins
instead of just float's fragment inline size.

3) Fix the calculation of NGFloatingObject::left_offset
(it's used if float is attached to the new parent) for right floats

4) Fix incorrectly attached legacy floating objects.

BUG=635619
TESTS=NGBlockLayoutAlgorithmTest::PositionFloatInsideEmptyBlocks,

Review-Url: https://codereview.chromium.org/2709083002
Cr-Commit-Position: refs/heads/master@{#452189}
Committed: https://chromium.googlesource.com/chromium/src/+/977c1dd577174ab7e8b9fd7686a4fa84011511d5

[Gleb Lanbin, 2017-02-21 23:58:51]

Patchset #1 (id:1) has been deleted

[Gleb Lanbin, 2017-02-21 23:59:40]

glebl@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[ikilpatrick, 2017-02-22 18:04:36]

lgtm.

https://codereview.chromium.org/2709083002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
(right):

https://codereview.chromium.org/2709083002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:213:
LayoutUnit float_box_inline_size =
float_margin_box_inline_size? (up to you)

https://codereview.chromium.org/2709083002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
(right):

https://codereview.chromium.org/2709083002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc:889:
auto left_float_fragment =
is this an auto* (or is this a RefPtr?)

[Gleb Lanbin, 2017-02-22 18:47:17]

thanks for the review.

https://codereview.chromium.org/2709083002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
(right):

https://codereview.chromium.org/2709083002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:213:
LayoutUnit float_box_inline_size =
On 2017/02/22 18:04:36, ikilpatrick wrote:
> float_margin_box_inline_size? (up to you)

Done.

https://codereview.chromium.org/2709083002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
(right):

https://codereview.chromium.org/2709083002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc:889:
auto left_float_fragment =
On 2017/02/22 18:04:36, ikilpatrick wrote:
> is this an auto* (or is this a RefPtr?)

Done.

[Gleb Lanbin, 2017-02-22 18:47:22]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2017-02-22 18:47:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2709083002/#ps40001
(title: "fix comments")

[commit-bot: I haz the power, 2017-02-22 18:48:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 20:44:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487789242239790,
"parent_rev": "cb4e0caa63778779d1fadfe2b31e418e6502f8c0", "commit_rev":
"977c1dd577174ab7e8b9fd7686a4fa84011511d5"}

[commit-bot: I haz the power, 2017-02-22 20:45:29]

Description was changed from

==========
Fix incorrectly painted right floats in LayoutNG

This patch fixes several problems discovered while investigating the
issue with incorrectly painted right floats in LayoutNG.

List of changes:

1) NGFloatingObject.parent_space was renamed to original_parent_space
This was discussed in http://crrev.com/2679343004

2) While calculating an additional offset for right floats we need to
use float's box size == float's fragment inline size + float's margins
instead of just float's fragment inline size.

3) Fix the calculation of NGFloatingObject::left_offset
(it's used if float is attached to the new parent) for right floats

4) Fix incorrectly attached legacy floating objects.

BUG=635619
TESTS=NGBlockLayoutAlgorithmTest::PositionFloatInsideEmptyBlocks,
==========

to

==========
Fix incorrectly painted right floats in LayoutNG

This patch fixes several problems discovered while investigating the
issue with incorrectly painted right floats in LayoutNG.

List of changes:

1) NGFloatingObject.parent_space was renamed to original_parent_space
This was discussed in http://crrev.com/2679343004

2) While calculating an additional offset for right floats we need to
use float's box size == float's fragment inline size + float's margins
instead of just float's fragment inline size.

3) Fix the calculation of NGFloatingObject::left_offset
(it's used if float is attached to the new parent) for right floats

4) Fix incorrectly attached legacy floating objects.

BUG=635619
TESTS=NGBlockLayoutAlgorithmTest::PositionFloatInsideEmptyBlocks,

Review-Url: https://codereview.chromium.org/2709083002
Cr-Commit-Position: refs/heads/master@{#452189}
Committed:
https://chromium.googlesource.com/chromium/src/+/977c1dd577174ab7e8b9fd7686a4...
==========

[commit-bot: I haz the power, 2017-02-22 20:45:30]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/977c1dd577174ab7e8b9fd7686a4...