Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2709043002: remove old way of collecting dependencies for dump-info (Closed)

Created:
3 years, 10 months ago by Harry Terkelsen
Modified:
3 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

remove old way of collecting dependencies for dump-info The new way of collecting dependencies covers everything from the old way, and does not have any spurious dependencies that the old way had. Fixes https://github.com/dart-lang/sdk/issues/28849 R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/fce2935ef5c1de8fcdd5da816c2fe898ca233a90

Patch Set 1 #

Total comments: 2

Patch Set 2 : use element.declaration #

Patch Set 3 : redo change after merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M pkg/compiler/lib/src/dump_info.dart View 1 2 4 chunks +20 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Harry Terkelsen
3 years, 10 months ago (2017-02-21 22:07:42 UTC) #2
Johnni Winther
Nice! LGTM https://codereview.chromium.org/2709043002/diff/1/pkg/compiler/lib/src/dump_info.dart File pkg/compiler/lib/src/dump_info.dart (right): https://codereview.chromium.org/2709043002/diff/1/pkg/compiler/lib/src/dump_info.dart#newcode421 pkg/compiler/lib/src/dump_info.dart:421: if (element.isPatch) { Equivalent to `element = ...
3 years, 10 months ago (2017-02-22 13:29:38 UTC) #3
Harry Terkelsen
https://codereview.chromium.org/2709043002/diff/1/pkg/compiler/lib/src/dump_info.dart File pkg/compiler/lib/src/dump_info.dart (right): https://codereview.chromium.org/2709043002/diff/1/pkg/compiler/lib/src/dump_info.dart#newcode421 pkg/compiler/lib/src/dump_info.dart:421: if (element.isPatch) { On 2017/02/22 13:29:38, Johnni Winther wrote: ...
3 years, 10 months ago (2017-02-22 20:53:14 UTC) #4
Harry Terkelsen
3 years, 10 months ago (2017-02-22 20:53:57 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
fce2935ef5c1de8fcdd5da816c2fe898ca233a90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698