Migrate WTF::HashMap::get() to ::at()

Migrate WTF::HashMap::get() to ::at()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2709033003
Cr-Commit-Position: refs/heads/master@{#452504}
Committed: https://chromium.googlesource.com/chromium/src/+/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c

[pilgrim_google, 2017-02-22 17:59:54]

pilgrim@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, yutak@chromium.org

[pilgrim_google, 2017-02-22 18:00:02]

Description was changed from

==========
Migrate WTF::HashMap::get() to ::at()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

to

==========
Migrate WTF::HashMap::get() to ::at()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[pilgrim_google, 2017-02-22 18:00:04]

Description was changed from

==========
Migrate WTF::HashMap::get() to ::at()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Migrate WTF::HashMap::get() to ::at()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[pilgrim_google, 2017-02-22 18:00:13]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 18:00:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 18:17:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 18:17:39]

Dry run: Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[pilgrim_google, 2017-02-22 19:38:11]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 19:39:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 19:57:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 19:57:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[pilgrim_google, 2017-02-22 21:08:39]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 21:09:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 21:42:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 21:43:00]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[haraken, 2017-02-22 23:29:57]

LGTM

[pilgrim_google, 2017-02-22 23:42:08]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-02-22 23:42:09]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2709033003/#ps60001
(title: "rebase, fix platform specific reference in GlyphMetricsMap.h")

[commit-bot: I haz the power, 2017-02-22 23:43:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 00:14:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 00:14:45]

Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[pilgrim_google, 2017-02-23 04:22:46]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-02-23 04:22:47]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2709033003/#ps80001
(title: "rebase, fix platform specific reference in ScrollbarThemeMac.mm")

[commit-bot: I haz the power, 2017-02-23 04:23:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 06:07:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 06:07:23]

Failed to apply patch for
third_party/WebKit/Source/platform/network/ParsedContentType.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/platform/network/ParsedContentType.cpp:164
  error: third_party/WebKit/Source/platform/network/ParsedContentType.cpp: patch
does not apply

Patch:       third_party/WebKit/Source/platform/network/ParsedContentType.cpp
Index: third_party/WebKit/Source/platform/network/ParsedContentType.cpp
diff --git a/third_party/WebKit/Source/platform/network/ParsedContentType.cpp
b/third_party/WebKit/Source/platform/network/ParsedContentType.cpp
index
e7e6880b9c89d4f80af199899a1511082274730b..8718abd20f92f50052b34281093f776a4e709f64
100644
--- a/third_party/WebKit/Source/platform/network/ParsedContentType.cpp
+++ b/third_party/WebKit/Source/platform/network/ParsedContentType.cpp
@@ -164,7 +164,7 @@ String ParsedContentType::charset() const {
 }
 
 String ParsedContentType::parameterValueForName(const String& name) const {
-  return m_parameters.get(name);
+  return m_parameters.at(name);
 }
 
 size_t ParsedContentType::parameterCount() const {

[pilgrim_google, 2017-02-23 14:03:37]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-02-23 14:03:38]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2709033003/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-23 14:03:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 16:00:27]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1487858617487470,
"parent_rev": "95ffecbdb167104df9c8c8f86e1826cb17122078", "commit_rev":
"2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c"}

[commit-bot: I haz the power, 2017-02-23 16:01:16]

Description was changed from

==========
Migrate WTF::HashMap::get() to ::at()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Migrate WTF::HashMap::get() to ::at()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2709033003
Cr-Commit-Position: refs/heads/master@{#452504}
Committed:
https://chromium.googlesource.com/chromium/src/+/2fb6ae93c1a3a90f6d3576d50ad8...
==========

[commit-bot: I haz the power, 2017-02-23 16:01:19]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/2fb6ae93c1a3a90f6d3576d50ad8...