Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2709033002:
Disable the DCHECK on id because of some flaky tests (Closed)
|
Created:
3 years, 10 months ago by lanwei Modified:
3 years, 10 months ago Reviewers:
Rick Byers CC:
chromium-reviews, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable the DCHECK on id because of some flaky tests
There are some flaky tests failed on
[1:1:0220/085659.710205:FATAL:PointerEventFactory.cpp(276)] Check failed:
mouseEvent.id == coalescedMouseEvent.id (2147483647 vs. 0)
We are currently disabling this DCHECK. We will inject id from low-level OS events
and add this DCHECK back again.
BUG=684292, 694403
Review-Url: https://codereview.chromium.org/2709033002
Cr-Commit-Position: refs/heads/master@{#452064}
Committed: https://chromium.googlesource.com/chromium/src/+/936e699a3399c5699d5ab30490707f8918e9fc08
Patch Set 1 #
Messages
Total messages: 22 (16 generated)
The CQ bit was checked by lanwei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== remove dcheck BUG=684292, 694403 ========== to ========== Disable the DCHECK on id because of some flaky tests There are some flaky tests failed on [1:1:0220/085659.710205:FATAL:PointerEventFactory.cpp(276)] Check failed: mouseEvent.id == coalescedMouseEvent.id (2147483647 vs. 0) We are currently disabling this DCHECK. We will inject id from low-level OS events and add this DCHECK back again. BUG=684292, 694403 ==========
Description was changed from ========== Disable the DCHECK on id because of some flaky tests There are some flaky tests failed on [1:1:0220/085659.710205:FATAL:PointerEventFactory.cpp(276)] Check failed: mouseEvent.id == coalescedMouseEvent.id (2147483647 vs. 0) We are currently disabling this DCHECK. We will inject id from low-level OS events and add this DCHECK back again. BUG=684292, 694403 ========== to ========== Disable the DCHECK on id because of some flaky tests There are some flaky tests failed on [1:1:0220/085659.710205:FATAL:PointerEventFactory.cpp(276)] Check failed: mouseEvent.id == coalescedMouseEvent.id (2147483647 vs. 0) We are currently disabling this DCHECK. We will inject id from low-level OS events and add this DCHECK back again. BUG=684292, 694403 ==========
lanwei@chromium.org changed reviewers: + rbyers@chromium.org
Looks like this landed already on Saturday: https://chromium.googlesource.com/chromium/src.git/+/47542d73322fa629f5d02975...
Whoops, my bad - sorry. There are two similar but distinct DCHECKs next to eachother here, I agree they should probably either both be enabled or both disabled. LGTM.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by lanwei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by lanwei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by lanwei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487777423771390, "parent_rev":
"3ab039df2d54013b3b72a450928ea65501695569", "commit_rev":
"936e699a3399c5699d5ab30490707f8918e9fc08"}
Message was sent while issue was closed.
Description was changed from ========== Disable the DCHECK on id because of some flaky tests There are some flaky tests failed on [1:1:0220/085659.710205:FATAL:PointerEventFactory.cpp(276)] Check failed: mouseEvent.id == coalescedMouseEvent.id (2147483647 vs. 0) We are currently disabling this DCHECK. We will inject id from low-level OS events and add this DCHECK back again. BUG=684292, 694403 ========== to ========== Disable the DCHECK on id because of some flaky tests There are some flaky tests failed on [1:1:0220/085659.710205:FATAL:PointerEventFactory.cpp(276)] Check failed: mouseEvent.id == coalescedMouseEvent.id (2147483647 vs. 0) We are currently disabling this DCHECK. We will inject id from low-level OS events and add this DCHECK back again. BUG=684292, 694403 Review-Url: https://codereview.chromium.org/2709033002 Cr-Commit-Position: refs/heads/master@{#452064} Committed: https://chromium.googlesource.com/chromium/src/+/936e699a3399c5699d5ab3049070... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/936e699a3399c5699d5ab3049070... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
