Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 2709013003: mediaview: Implement ArcDocumentsProviderWatcherManager. (Closed)

Created:
3 years, 10 months ago by Shuhei Takahashi
Modified:
3 years, 9 months ago
Reviewers:
hidehiko, mtomasz
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tzik, hidehiko+watch_chromium.org, nhiroki, lhchavez+watch_chromium.org, oshima+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mediaview: Implement ArcDocumentsProviderWatcherManager. ArcDocumentsProviderWatcherManager simply calls ArcDocumentsProviderRoot. BUG=chromium:684233 TEST=trybot TEST=Media view refreshes on media provider changes. Review-Url: https://codereview.chromium.org/2709013003 Cr-Commit-Position: refs/heads/master@{#454598} Committed: https://chromium.googlesource.com/chromium/src/+/7b44260f27f6b52b3a1b81e81cdedeb8164b4497

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : Review ready. #

Total comments: 2

Patch Set 5 : Rebased to ToT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -3 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/fileapi/arc_documents_provider_backend_delegate.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/fileapi/arc_documents_provider_backend_delegate.cc View 2 chunks +2 lines, -3 lines 0 comments Download
A chrome/browser/chromeos/arc/fileapi/arc_documents_provider_watcher_manager.h View 1 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/arc/fileapi/arc_documents_provider_watcher_manager.cc View 1 chunk +72 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/fileapi/file_system_backend.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (22 generated)
Shuhei Takahashi
hidehiko: PTAL
3 years, 9 months ago (2017-03-02 08:40:25 UTC) #14
Shuhei Takahashi
mtomasz: PTAL for chrome/browser/chromeos/fileapi
3 years, 9 months ago (2017-03-02 08:41:23 UTC) #16
mtomasz
lgtm with a question https://codereview.chromium.org/2709013003/diff/60001/chrome/browser/chromeos/fileapi/file_system_backend.cc File chrome/browser/chromeos/fileapi/file_system_backend.cc (right): https://codereview.chromium.org/2709013003/diff/60001/chrome/browser/chromeos/fileapi/file_system_backend.cc#newcode10 chrome/browser/chromeos/fileapi/file_system_backend.cc:10: #include <utility> nit: Is this ...
3 years, 9 months ago (2017-03-02 08:50:18 UTC) #17
Shuhei Takahashi
https://codereview.chromium.org/2709013003/diff/60001/chrome/browser/chromeos/fileapi/file_system_backend.cc File chrome/browser/chromeos/fileapi/file_system_backend.cc (right): https://codereview.chromium.org/2709013003/diff/60001/chrome/browser/chromeos/fileapi/file_system_backend.cc#newcode10 chrome/browser/chromeos/fileapi/file_system_backend.cc:10: #include <utility> On 2017/03/02 08:50:18, mtomasz wrote: > nit: ...
3 years, 9 months ago (2017-03-02 08:51:31 UTC) #18
hidehiko
c/b/c/arc LGTM.
3 years, 9 months ago (2017-03-02 14:51:23 UTC) #19
commit-bot: I haz the power
This CL has an open dependency (Issue 2715473003 Patch 120001). Please resolve the dependency and ...
3 years, 9 months ago (2017-03-03 15:36:21 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709013003/60001
3 years, 9 months ago (2017-03-03 15:49:31 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/164335) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-03 15:51:39 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709013003/80001
3 years, 9 months ago (2017-03-03 16:01:30 UTC) #29
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 16:56:54 UTC) #32
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7b44260f27f6b52b3a1b81e81cde...

Powered by Google App Engine
This is Rietveld 408576698