Fix of flaky SdchTest#testSdchEnabled test.

Fix of flaky SdchTest#testSdchEnabled test.

BUG=657413
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2709003002
Cr-Commit-Position: refs/heads/master@{#451872}
Committed: https://chromium.googlesource.com/chromium/src/+/5ccaaeacdde0e1029f3f5e42d369f28ee9c1329c

[kapishnikov, 2017-02-21 19:27:16]

Description was changed from

==========
Fix of flaky SdchTest#testSdchEnabled test.

BUG=657413
==========

to

==========
Fix of flaky SdchTest#testSdchEnabled test.

BUG=657413
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[kapishnikov, 2017-02-21 19:29:08]

kapishnikov@chromium.org changed reviewers:
+ xunjieli@chromium.org

[kapishnikov, 2017-02-21 19:29:08]

This should fix the flaky SdchTest#testSdchEnabled test. PTAL.

[xunjieli, 2017-02-21 20:11:34]

LGTM! thanks for investigating and fixing this long-standing flaky test!

https://codereview.chromium.org/2709003002/diff/1/components/cronet/android/t...
File components/cronet/android/test/src/org/chromium/net/SdchObserver.java
(right):

https://codereview.chromium.org/2709003002/diff/1/components/cronet/android/t...
components/cronet/android/test/src/org/chromium/net/SdchObserver.java:22:
private static final int BLOCK_WAIT_TIMEOUT_SEC = 20;
nit: static before non-static fields.

[kapishnikov, 2017-02-21 20:30:55]

Thanks!

https://codereview.chromium.org/2709003002/diff/1/components/cronet/android/t...
File components/cronet/android/test/src/org/chromium/net/SdchObserver.java
(right):

https://codereview.chromium.org/2709003002/diff/1/components/cronet/android/t...
components/cronet/android/test/src/org/chromium/net/SdchObserver.java:22:
private static final int BLOCK_WAIT_TIMEOUT_SEC = 20;
On 2017/02/21 20:11:34, xunjieli wrote:
> nit: static before non-static fields.

Done.

[kapishnikov, 2017-02-21 20:31:05]

The CQ bit was checked by kapishnikov@chromium.org

[kapishnikov, 2017-02-21 20:31:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/2709003002/#ps20001
(title: "Moved static field before non-static.")

[commit-bot: I haz the power, 2017-02-21 20:33:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 22:37:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 22:37:43]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[kapishnikov, 2017-02-21 23:15:56]

The CQ bit was checked by kapishnikov@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:18:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 01:26:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487718956691810,
"parent_rev": "5d8ee17466e0bad64f0859d2918e86a98ec5bd83", "commit_rev":
"5ccaaeacdde0e1029f3f5e42d369f28ee9c1329c"}

[commit-bot: I haz the power, 2017-02-22 01:27:36]

Description was changed from

==========
Fix of flaky SdchTest#testSdchEnabled test.

BUG=657413
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Fix of flaky SdchTest#testSdchEnabled test.

BUG=657413
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2709003002
Cr-Commit-Position: refs/heads/master@{#451872}
Committed:
https://chromium.googlesource.com/chromium/src/+/5ccaaeacdde0e1029f3f5e42d369...
==========

[commit-bot: I haz the power, 2017-02-22 01:27:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5ccaaeacdde0e1029f3f5e42d369...