Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2709003002: Fix of flaky SdchTest#testSdchEnabled test. (Closed)

Created:
3 years, 10 months ago by kapishnikov
Modified:
3 years, 10 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix of flaky SdchTest#testSdchEnabled test. BUG=657413 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2709003002 Cr-Commit-Position: refs/heads/master@{#451872} Committed: https://chromium.googlesource.com/chromium/src/+/5ccaaeacdde0e1029f3f5e42d369f28ee9c1329c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moved static field before non-static. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -36 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/SdchTest.java View 4 chunks +2 lines, -25 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/SdchObserver.java View 1 3 chunks +22 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
kapishnikov
This should fix the flaky SdchTest#testSdchEnabled test. PTAL.
3 years, 10 months ago (2017-02-21 19:29:08 UTC) #3
xunjieli
LGTM! thanks for investigating and fixing this long-standing flaky test! https://codereview.chromium.org/2709003002/diff/1/components/cronet/android/test/src/org/chromium/net/SdchObserver.java File components/cronet/android/test/src/org/chromium/net/SdchObserver.java (right): https://codereview.chromium.org/2709003002/diff/1/components/cronet/android/test/src/org/chromium/net/SdchObserver.java#newcode22 ...
3 years, 10 months ago (2017-02-21 20:11:34 UTC) #4
kapishnikov
Thanks! https://codereview.chromium.org/2709003002/diff/1/components/cronet/android/test/src/org/chromium/net/SdchObserver.java File components/cronet/android/test/src/org/chromium/net/SdchObserver.java (right): https://codereview.chromium.org/2709003002/diff/1/components/cronet/android/test/src/org/chromium/net/SdchObserver.java#newcode22 components/cronet/android/test/src/org/chromium/net/SdchObserver.java:22: private static final int BLOCK_WAIT_TIMEOUT_SEC = 20; On ...
3 years, 10 months ago (2017-02-21 20:30:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709003002/20001
3 years, 10 months ago (2017-02-21 20:33:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-21 22:37:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709003002/20001
3 years, 10 months ago (2017-02-21 23:18:03 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 01:27:43 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5ccaaeacdde0e1029f3f5e42d369...

Powered by Google App Engine
This is Rietveld 408576698