Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2708993003:
Fix issue where side nav wasn't updated every time the route changed. (Closed)
|
Created:
3 years, 10 months ago by hcarmona Modified:
3 years, 10 months ago Reviewers:
tommycli CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix issue where side nav wasn't updated every time the route changed.
BUG=694186
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2708993003
Cr-Commit-Position: refs/heads/master@{#452209}
Committed: https://chromium.googlesource.com/chromium/src/+/eddd7d9f355c397453f99e1ea1978568f7e103c4
Patch Set 1 #Patch Set 2 : add tests #
Messages
Total messages: 22 (14 generated)
Description was changed from ========== Fix issue where side nav wasn't updated every time the route changed. BUG=694186 ========== to ========== Fix issue where side nav wasn't updated every time the route changed. BUG=694186 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hcarmona@chromium.org changed reviewers: + tommycli@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
lgtm could be worth a test if this regressed. I could go either way but i leave it up to you.
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Added tests, PTAL
awesome test. lgtm++
The CQ bit was unchecked by hcarmona@chromium.org
The CQ bit was checked by hcarmona@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
The CQ bit was checked by hcarmona@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487798312913210,
"parent_rev": "d6f69d9b551e64dae8d9fca247116de7827c2a76", "commit_rev":
"eddd7d9f355c397453f99e1ea1978568f7e103c4"}
Message was sent while issue was closed.
Description was changed from ========== Fix issue where side nav wasn't updated every time the route changed. BUG=694186 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix issue where side nav wasn't updated every time the route changed. BUG=694186 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2708993003 Cr-Commit-Position: refs/heads/master@{#452209} Committed: https://chromium.googlesource.com/chromium/src/+/eddd7d9f355c397453f99e1ea197... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/eddd7d9f355c397453f99e1ea197... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
