Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2708983004: Remove MiddleClickAutoscroll from chrome://flags. (Closed)

Created:
3 years, 10 months ago by sunyunjia
Modified:
3 years, 10 months ago
Reviewers:
dtapuska, Rick Byers
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MiddleClickAutoscroll from chrome://flags. Previously, MiddleClickAutoscroll on Linux can be enabled through Experimental Web Platform flag in chrome://flags. However, it is usually unconsciously enabled and raises many problems. This patch disallows the change of this flag from about://flags and only allows it to be enabled by command line. BUG=683637 Review-Url: https://codereview.chromium.org/2708983004 Cr-Commit-Position: refs/heads/master@{#452332} Committed: https://chromium.googlesource.com/chromium/src/+/2ca532da23962857f4fda21095baaf227249f86c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
sunyunjia
PTAL, thanks!
3 years, 10 months ago (2017-02-22 19:44:26 UTC) #4
Rick Byers
LGTM
3 years, 10 months ago (2017-02-22 21:54:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708983004/1
3 years, 10 months ago (2017-02-23 01:30:40 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 01:38:29 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2ca532da23962857f4fda21095ba...

Powered by Google App Engine
This is Rietveld 408576698