Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2708963002:
Fix potential DCHECK in TaskQueueThrottler::IncreaseThrottleRefCount (Closed)
|
Created:
3 years, 10 months ago by alex clarke (OOO till 29th) Modified:
3 years, 10 months ago CC:
chromium-reviews, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix potential DCHECK in TaskQueueThrottler::IncreaseThrottleRefCount
If TaskQueueThrottler::IncreaseThrottleRefCount was called on a
disabled task queue whose next task was delayed, then a DCHECK in
OnTimeDomainHasDelayedWork could fire. This patch prevents that from
happening.
This may fix the cluster fuzz warning too.
BUG=693096, 693798
Review-Url: https://codereview.chromium.org/2708963002
Cr-Commit-Position: refs/heads/master@{#451999}
Committed: https://chromium.googlesource.com/chromium/src/+/85ed9bafd675dc129eebb238ac3c679d436e5d40
Patch Set 1 #
Total comments: 6
Patch Set 2 : Fix bug with re-enabling queue with immediate work #
Total comments: 2
Patch Set 3 : Addressing review comments. #
Messages
Total messages: 31 (21 generated)
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
Description was changed from ========== Fix potential DCHECK in TaskQueueThrottler::IncreaseThrottleRefCount If TaskQueueThrottler::IncreaseThrottleRefCount was called on a disabled task queue whose next task was delayed, then a DCHECK in OnTimeDomainHasDelayedWork could fire. This patch prevents that from happening. This may fix the cluster fuzz warning too. BUG=693096 ========== to ========== Fix potential DCHECK in TaskQueueThrottler::IncreaseThrottleRefCount If TaskQueueThrottler::IncreaseThrottleRefCount was called on a disabled task queue whose next task was delayed, then a DCHECK in OnTimeDomainHasDelayedWork could fire. This patch prevents that from happening. This may fix the cluster fuzz warning too. BUG=693096 ==========
alexclarke@chromium.org changed reviewers: + altimin@chromium.org, skyostil@chromium.org
PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/02/21 17:44:05, alex clarke wrote: > PTAL lgtm with nits.
https://codereview.chromium.org/2708963002/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc (right): https://codereview.chromium.org/2708963002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc:266: ThrotlingADisaledQueueDoesNotPostPumpThrottledTasksLocked) { Nit: throttling, disabled. https://codereview.chromium.org/2708963002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc:279: ThrotlingADisaledQueueDoesNotPostPumpThrottledTasksLocked_DelayedTask) { Nit: the same.
PTAL https://codereview.chromium.org/2708963002/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc (right): https://codereview.chromium.org/2708963002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc:266: ThrotlingADisaledQueueDoesNotPostPumpThrottledTasksLocked) { On 2017/02/21 17:48:31, altimin wrote: > Nit: throttling, disabled. Done. https://codereview.chromium.org/2708963002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc:279: ThrotlingADisaledQueueDoesNotPostPumpThrottledTasksLocked_DelayedTask) { On 2017/02/21 17:48:31, altimin wrote: > Nit: the same. Done.
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2708963002/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc (right): https://codereview.chromium.org/2708963002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc:266: ThrotlingADisaledQueueDoesNotPostPumpThrottledTasksLocked) { On 2017/02/21 17:48:31, altimin wrote: > Nit: throttling, disabled. Also, the "Locked" part seems obsolete. https://codereview.chromium.org/2708963002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc (right): https://codereview.chromium.org/2708963002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:811: main_thread_only().time_domain->OnQueueHasImmediateWork(this); Should we call this outside the lock? Thinking about re-entrancy...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
PTAL https://codereview.chromium.org/2708963002/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc (right): https://codereview.chromium.org/2708963002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc:266: ThrotlingADisaledQueueDoesNotPostPumpThrottledTasksLocked) { On 2017/02/21 18:21:02, Sami wrote: > On 2017/02/21 17:48:31, altimin wrote: > > Nit: throttling, disabled. > > Also, the "Locked" part seems obsolete. Done.
https://codereview.chromium.org/2708963002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc (right): https://codereview.chromium.org/2708963002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc:811: main_thread_only().time_domain->OnQueueHasImmediateWork(this); On 2017/02/21 18:21:02, Sami wrote: > Should we call this outside the lock? Thinking about re-entrancy... Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Fix potential DCHECK in TaskQueueThrottler::IncreaseThrottleRefCount If TaskQueueThrottler::IncreaseThrottleRefCount was called on a disabled task queue whose next task was delayed, then a DCHECK in OnTimeDomainHasDelayedWork could fire. This patch prevents that from happening. This may fix the cluster fuzz warning too. BUG=693096 ========== to ========== Fix potential DCHECK in TaskQueueThrottler::IncreaseThrottleRefCount If TaskQueueThrottler::IncreaseThrottleRefCount was called on a disabled task queue whose next task was delayed, then a DCHECK in OnTimeDomainHasDelayedWork could fire. This patch prevents that from happening. This may fix the cluster fuzz warning too. BUG=693096, 693798 ==========
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by alexclarke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from altimin@chromium.org Link to the patchset: https://codereview.chromium.org/2708963002/#ps40001 (title: "Addressing review comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487763758157270,
"parent_rev": "c36340833135933c5934ece592fb41b82743e2d8", "commit_rev":
"85ed9bafd675dc129eebb238ac3c679d436e5d40"}
Message was sent while issue was closed.
Description was changed from ========== Fix potential DCHECK in TaskQueueThrottler::IncreaseThrottleRefCount If TaskQueueThrottler::IncreaseThrottleRefCount was called on a disabled task queue whose next task was delayed, then a DCHECK in OnTimeDomainHasDelayedWork could fire. This patch prevents that from happening. This may fix the cluster fuzz warning too. BUG=693096, 693798 ========== to ========== Fix potential DCHECK in TaskQueueThrottler::IncreaseThrottleRefCount If TaskQueueThrottler::IncreaseThrottleRefCount was called on a disabled task queue whose next task was delayed, then a DCHECK in OnTimeDomainHasDelayedWork could fire. This patch prevents that from happening. This may fix the cluster fuzz warning too. BUG=693096, 693798 Review-Url: https://codereview.chromium.org/2708963002 Cr-Commit-Position: refs/heads/master@{#451999} Committed: https://chromium.googlesource.com/chromium/src/+/85ed9bafd675dc129eebb238ac3c... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/85ed9bafd675dc129eebb238ac3c... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
