Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2708923008: Revert of Print creator's call-stack on URLRequestContextGetter leak in Debug. (Closed)

Created:
3 years, 10 months ago by Wez
Modified:
3 years, 10 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Print creator's call-stack on URLRequestContextGetter leak in Debug. (patchset #1 id:1 of https://codereview.chromium.org/2702083002/ ) Reason for revert: This output is too noisy on browser shutdown, where is apparently now expected that we leak things. Original issue's description: > Print creator's call-stack on URLRequestContextGetter leak in Debug. > > This adds a StackTrace member to the URLRequestContextGetter base, to > allow the call-stack that created the instance to be printed in case > of it having to be leaked because of the owning thread having gone away. > > BUG=693965 > > Review-Url: https://codereview.chromium.org/2702083002 > Cr-Commit-Position: refs/heads/master@{#452289} > Committed: https://chromium.googlesource.com/chromium/src/+/c59596d13ec0e105c72dd69661b8bcb505d9afa7 TBR=rsleevi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=693965 Review-Url: https://codereview.chromium.org/2708923008 Cr-Commit-Position: refs/heads/master@{#452605} Committed: https://chromium.googlesource.com/chromium/src/+/55fa5c6ec96a1f955cf0c3a85b6689239e8ab08e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M net/url_request/url_request_context_getter.h View 2 chunks +0 lines, -5 lines 0 comments Download
M net/url_request/url_request_context_getter.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Wez
Created Revert of Print creator's call-stack on URLRequestContextGetter leak in Debug.
3 years, 10 months ago (2017-02-23 20:23:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708923008/1
3 years, 10 months ago (2017-02-23 20:23:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/55fa5c6ec96a1f955cf0c3a85b6689239e8ab08e
3 years, 10 months ago (2017-02-23 20:25:07 UTC) #6
Ryan Sleevi
3 years, 10 months ago (2017-02-23 20:25:21 UTC) #7
Message was sent while issue was closed.
LGTM & sorry for confusion. I thought you were hoping to burn down the
non-browser case

Powered by Google App Engine
This is Rietveld 408576698