DescriptionRevert of Fix repeated "-Wunknown-pragmas -Wno-error=unknown-pragmas". (patchset #2 id:40001 of https://codereview.chromium.org/2717493002/ )
Reason for revert:
Looks like this CL is breaking Android Compile on chromium.perf.
https://bugs.chromium.org/p/chromium/issues/detail?id=695534
Original issue's description:
> Fix repeated "-Wunknown-pragmas -Wno-error=unknown-pragmas".
>
> As gn only deduplicate the configs but not the configs' flags, the
> flags "-Wunknown-pragmas -Wno-error=unknown-pragmas" where repeated
> for each dependent target using the "grit" template. Instead add a
> single config adding those flag and reference it from the "grit"
> template to avoid the duplicates.
>
> BUG=None
>
> Review-Url: https://codereview.chromium.org/2717493002
> Cr-Commit-Position: refs/heads/master@{#452543}
> Committed: https://chromium.googlesource.com/chromium/src/+/f673f4c59c985aa8ddfab2b3821c42af25d915e4
TBR=lizeb@chromium.org,scottmg@chromium.org,sdefresne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review-Url: https://codereview.chromium.org/2708923007
Cr-Commit-Position: refs/heads/master@{#452595}
Committed: https://chromium.googlesource.com/chromium/src/+/b6c06ef04f90d35dcbdd08c083befa94152c1320
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|