Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2708923007: Revert of Fix repeated "-Wunknown-pragmas -Wno-error=unknown-pragmas". (Closed)

Created:
3 years, 10 months ago by prasadv
Modified:
3 years, 10 months ago
Reviewers:
Benoit L, sdefresne, scottmg
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix repeated "-Wunknown-pragmas -Wno-error=unknown-pragmas". (patchset #2 id:40001 of https://codereview.chromium.org/2717493002/ ) Reason for revert: Looks like this CL is breaking Android Compile on chromium.perf. https://bugs.chromium.org/p/chromium/issues/detail?id=695534 Original issue's description: > Fix repeated "-Wunknown-pragmas -Wno-error=unknown-pragmas". > > As gn only deduplicate the configs but not the configs' flags, the > flags "-Wunknown-pragmas -Wno-error=unknown-pragmas" where repeated > for each dependent target using the "grit" template. Instead add a > single config adding those flag and reference it from the "grit" > template to avoid the duplicates. > > BUG=None > > Review-Url: https://codereview.chromium.org/2717493002 > Cr-Commit-Position: refs/heads/master@{#452543} > Committed: https://chromium.googlesource.com/chromium/src/+/f673f4c59c985aa8ddfab2b3821c42af25d915e4 TBR=lizeb@chromium.org,scottmg@chromium.org,sdefresne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2708923007 Cr-Commit-Position: refs/heads/master@{#452595} Committed: https://chromium.googlesource.com/chromium/src/+/b6c06ef04f90d35dcbdd08c083befa94152c1320

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -15 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
M tools/grit/grit_rule.gni View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
prasadv
Created Revert of Fix repeated "-Wunknown-pragmas -Wno-error=unknown-pragmas".
3 years, 10 months ago (2017-02-23 19:46:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708923007/1
3 years, 10 months ago (2017-02-23 19:46:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b6c06ef04f90d35dcbdd08c083befa94152c1320
3 years, 10 months ago (2017-02-23 19:57:45 UTC) #6
sdefresne
3 years, 10 months ago (2017-02-24 09:48:42 UTC) #7
Message was sent while issue was closed.
On 2017/02/23 19:57:45, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/b6c06ef04f90d35dcbdd08c083be...

lgtm

Thank you for reverting.

Powered by Google App Engine
This is Rietveld 408576698