[Password Manager] New criteria for submission detection.

[Password Manager] New criteria for a submission detection.

In order to understand that form submission was successful, Password Manager uses very simple criteria: the submission is considered to be successful iff the form is disappeared from the DOM. It fails especially often on change password form, since it's ok for change password form to be in DOM after successful change password, since the user can change password again. This CL implements additional criteria for change password forms: submissions is successful iff the form is disappeared or its fields are cleared.

BUG=597309, 683950
Review-Url: https://codereview.chromium.org/2708923006
Cr-Commit-Position: refs/heads/master@{#452505}
Committed: https://chromium.googlesource.com/chromium/src/+/1292fd1de885beaaa353f8d200b62199a625754f

[dvadym, 2017-02-23 13:22:47]

Description was changed from

==========
format


Test added


Merge branch 'master' into cpf_success_detection


format


Test added


format


firmst impl

BUG=None
==========

to

==========
[Password Manager] New criteria for a submission detection.

In order to understand that form submission was successful, Password Manager
uses very simple criteria: the submission is considered to be successful iff the
form is disappeared from the DOM. It fails especially often on change password
form, since it's ok for change password form to be in DOM after successful
change password, since the user can change password again. This CL implements
additional criteria for change password forms: submissions is successful iff the
form is disappeared or its fields are cleared.

BUG=597309, 683950
==========

[dvadym, 2017-02-23 13:22:47]

dvadym@chromium.org changed reviewers:
+ kolos@chromium.org

[dvadym, 2017-02-23 13:25:12]

Hi Maxim,

 could you please have a look?

Regards,
Vadym

[kolos1, 2017-02-23 15:06:06]

LGTM

[dvadym, 2017-02-23 15:21:32]

The CQ bit was checked by dvadym@chromium.org

[commit-bot: I haz the power, 2017-02-23 15:21:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 16:03:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487863292400490,
"parent_rev": "2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c", "commit_rev":
"1292fd1de885beaaa353f8d200b62199a625754f"}

[commit-bot: I haz the power, 2017-02-23 16:04:15]

Description was changed from

==========
[Password Manager] New criteria for a submission detection.

In order to understand that form submission was successful, Password Manager
uses very simple criteria: the submission is considered to be successful iff the
form is disappeared from the DOM. It fails especially often on change password
form, since it's ok for change password form to be in DOM after successful
change password, since the user can change password again. This CL implements
additional criteria for change password forms: submissions is successful iff the
form is disappeared or its fields are cleared.

BUG=597309, 683950
==========

to

==========
[Password Manager] New criteria for a submission detection.

In order to understand that form submission was successful, Password Manager
uses very simple criteria: the submission is considered to be successful iff the
form is disappeared from the DOM. It fails especially often on change password
form, since it's ok for change password form to be in DOM after successful
change password, since the user can change password again. This CL implements
additional criteria for change password forms: submissions is successful iff the
form is disappeared or its fields are cleared.

BUG=597309, 683950

Review-Url: https://codereview.chromium.org/2708923006
Cr-Commit-Position: refs/heads/master@{#452505}
Committed:
https://chromium.googlesource.com/chromium/src/+/1292fd1de885beaaa353f8d200b6...
==========

[commit-bot: I haz the power, 2017-02-23 16:04:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1292fd1de885beaaa353f8d200b6...