|
|
Created:
3 years, 10 months ago by friedman Modified:
3 years, 10 months ago Reviewers:
Dirk Pranke, Tom (Use chromium acct), Lei Zhang, kjellander_chromium, Nico, Roland McGrath CC:
chromium-reviews, Dirk Pranke, Tom Anderson Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix arm-list for Precise (binutils-aarch64-linux-gnu doesn't exist there)
R=kjellander@chromium.org, mcgrathr@chromium.org, thakis@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2708913005
Cr-Commit-Position: refs/heads/master@{#452232}
Committed: https://chromium.googlesource.com/chromium/src/+/0eef9e491c2d50e0c8506aff89c1759bd3bb2348
Patch Set 1 #
Messages
Total messages: 21 (7 generated)
lgtm
thakis@chromium.org changed reviewers: + thestig@chromium.org
I don't know anything about this, but thestig is back
The CQ bit was checked by friedman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2017/02/22 at 19:42:28, commit-bot wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Need an owner. This is blocking setup of all Precise bots (ChromeOS).
On 2017/02/22 19:54:10, friedman wrote: > On 2017/02/22 at 19:42:28, commit-bot wrote: > > Try jobs failed on following builders: > > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) > > Need an owner. This is blocking setup of all Precise bots (ChromeOS). Pick someone from https://cs.chromium.org/chromium/src/build/OWNERS and/or ping them if it's urgent.
rs-lgtm
The CQ bit was checked by friedman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1487801631114980, "parent_rev": "e652268c22f4c50bb96762cc1c984cc0a758c009", "commit_rev": "0eef9e491c2d50e0c8506aff89c1759bd3bb2348"}
Message was sent while issue was closed.
Description was changed from ========== Fix arm-list for Precise (binutils-aarch64-linux-gnu doesn't exist there) R=kjellander@chromium.org, mcgrathr@chromium.org, thakis@chromium.org BUG= ========== to ========== Fix arm-list for Precise (binutils-aarch64-linux-gnu doesn't exist there) R=kjellander@chromium.org, mcgrathr@chromium.org, thakis@chromium.org BUG= Review-Url: https://codereview.chromium.org/2708913005 Cr-Commit-Position: refs/heads/master@{#452232} Committed: https://chromium.googlesource.com/chromium/src/+/0eef9e491c2d50e0c8506aff89c1... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0eef9e491c2d50e0c8506aff89c1...
Message was sent while issue was closed.
lgtm, though I'm curious what bot(s) are failing. dpranke@ can probably tell us when we can get rid of the checks for Precise. From his chromium-dev post, it sounds like Precise builders are on their way out but probably not all gone yet.
Message was sent while issue was closed.
On 2017/02/22 at 22:53:41, thestig wrote: > lgtm, though I'm curious what bot(s) are failing. > > dpranke@ can probably tell us when we can get rid of the checks for Precise. From his chromium-dev post, it sounds like Precise builders are on their way out but probably not all gone yet. All of the chromeos builders for now and a few remaining precise only builders outside of chromeos.
Message was sent while issue was closed.
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
Message was sent while issue was closed.
We were almost completely off of Precise until we tripped over crbug.com/693668 :(. Hopefully we'll get that resolved shortly and be done w/ it.
Message was sent while issue was closed.
On 2017/02/23 00:04:02, Dirk Pranke wrote: > We were almost completely off of Precise until we tripped over crbug.com/693668 > :(. Hopefully we'll get that resolved shortly and be done w/ it. retroactive lgtm, having just run into this today on a newly-created precise vm |