Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2708913005: Fix arm-list for Precise (binutils-aarch64-linux-gnu doesn't exist there) (Closed)

Created:
3 years, 10 months ago by friedman
Modified:
3 years, 10 months ago
CC:
chromium-reviews, Dirk Pranke, Tom Anderson
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix arm-list for Precise (binutils-aarch64-linux-gnu doesn't exist there) R=kjellander@chromium.org, mcgrathr@chromium.org, thakis@chromium.org BUG= Review-Url: https://codereview.chromium.org/2708913005 Cr-Commit-Position: refs/heads/master@{#452232} Committed: https://chromium.googlesource.com/chromium/src/+/0eef9e491c2d50e0c8506aff89c1759bd3bb2348

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/install-build-deps.sh View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 21 (7 generated)
friedman
3 years, 10 months ago (2017-02-22 00:55:06 UTC) #1
kjellander_chromium
lgtm
3 years, 10 months ago (2017-02-22 11:23:19 UTC) #2
Nico
I don't know anything about this, but thestig is back
3 years, 10 months ago (2017-02-22 18:24:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708913005/1
3 years, 10 months ago (2017-02-22 19:33:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/370406)
3 years, 10 months ago (2017-02-22 19:42:28 UTC) #8
friedman
On 2017/02/22 at 19:42:28, commit-bot wrote: > Try jobs failed on following builders: > chromium_presubmit ...
3 years, 10 months ago (2017-02-22 19:54:10 UTC) #9
kjellander_chromium
On 2017/02/22 19:54:10, friedman wrote: > On 2017/02/22 at 19:42:28, commit-bot wrote: > > Try ...
3 years, 10 months ago (2017-02-22 19:55:59 UTC) #10
Nico
rs-lgtm
3 years, 10 months ago (2017-02-22 20:30:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708913005/1
3 years, 10 months ago (2017-02-22 22:14:45 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0eef9e491c2d50e0c8506aff89c1759bd3bb2348
3 years, 10 months ago (2017-02-22 22:22:07 UTC) #16
Lei Zhang
lgtm, though I'm curious what bot(s) are failing. dpranke@ can probably tell us when we ...
3 years, 10 months ago (2017-02-22 22:53:41 UTC) #17
friedman
On 2017/02/22 at 22:53:41, thestig wrote: > lgtm, though I'm curious what bot(s) are failing. ...
3 years, 10 months ago (2017-02-22 23:13:59 UTC) #18
Dirk Pranke
We were almost completely off of Precise until we tripped over crbug.com/693668 :(. Hopefully we'll ...
3 years, 10 months ago (2017-02-23 00:04:02 UTC) #20
Tom (Use chromium acct)
3 years, 10 months ago (2017-02-23 00:09:25 UTC) #21
Message was sent while issue was closed.
On 2017/02/23 00:04:02, Dirk Pranke wrote:
> We were almost completely off of Precise until we tripped over
crbug.com/693668
> :(. Hopefully we'll get that resolved shortly and be done w/ it.

retroactive lgtm, having just run into this today on a newly-created precise vm

Powered by Google App Engine
This is Rietveld 408576698