Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 2708913004: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 Review-Url: https://codereview.chromium.org/2708913004 Cr-Commit-Position: refs/heads/master@{#452112} Committed: https://chromium.googlesource.com/chromium/src/+/3051b0d5f0603634df63e7919f26bde9b35d1d90

Patch Set 1 #

Total comments: 6

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/extensions/api/automation/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/automation_internal/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/automation/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-21 23:39:40 UTC) #2
David Tseng
https://codereview.chromium.org/2708913004/diff/1/chrome/browser/extensions/api/automation/OWNERS File chrome/browser/extensions/api/automation/OWNERS (right): https://codereview.chromium.org/2708913004/diff/1/chrome/browser/extensions/api/automation/OWNERS#newcode4 chrome/browser/extensions/api/automation/OWNERS:4: # COMPONENT: Platform>Extensions>API It should be UI>Accessibility https://codereview.chromium.org/2708913004/diff/1/chrome/browser/extensions/api/automation_internal/OWNERS File ...
3 years, 10 months ago (2017-02-22 00:04:30 UTC) #3
ymzhang1
https://codereview.chromium.org/2708913004/diff/1/chrome/browser/extensions/api/automation/OWNERS File chrome/browser/extensions/api/automation/OWNERS (right): https://codereview.chromium.org/2708913004/diff/1/chrome/browser/extensions/api/automation/OWNERS#newcode4 chrome/browser/extensions/api/automation/OWNERS:4: # COMPONENT: Platform>Extensions>API On 2017/02/22 00:04:30, David Tseng wrote: ...
3 years, 10 months ago (2017-02-22 00:16:50 UTC) #4
David Tseng
lgtm
3 years, 10 months ago (2017-02-22 16:17:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708913004/20001
3 years, 10 months ago (2017-02-22 17:28:19 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 17:40:34 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3051b0d5f0603634df63e7919f26...

Powered by Google App Engine
This is Rietveld 408576698